Page MenuHomePhabricator

[mips] Use multiclass patterns for f32/f64 comparisons and i32 selects.
ClosedPublic

Authored by vkalintiris on Nov 12 2015, 4:55 AM.

Details

Summary

Although the multiclass for i32 selects might seem redundant as it has
only one instantiation, we will use it to replace the correspondent
patterns in Mips64r6InstrInfo.td in follow-up commits.

Diff Detail

Repository
rL LLVM

Event Timeline

vkalintiris retitled this revision from to [mips] Use multiclass patterns for f32/f64 comparisons and i32 selects..
vkalintiris updated this object.
vkalintiris added a reviewer: dsanders.
vkalintiris added a subscriber: llvm-commits.
dsanders accepted this revision.Dec 8 2015, 3:37 AM
dsanders edited edge metadata.

LGTM with a nit.

lib/Target/Mips/Mips32r6InstrInfo.td
791 ↗(On Diff #40034)

'RC' normally means 'RegisterClass' in these files. Could you pick another name?

This revision is now accepted and ready to land.Dec 8 2015, 3:37 AM
This revision was automatically updated to reflect the committed changes.