Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

Differential D146010

[sancov] fix coverage-report-server cannot display coverage detail
ClosedPublic
Actions

Authored by HerrCai0907 on Mar 13 2023, 11:34 PM.

Tags

Subscribers

Details

Reviewers

vitalybuka
klimek
lattner

Commits

rGfb066c4622c8: [sancov] fix coverage-report-server cannot display coverage detail

Summary

This patch make following change for coverage-report-server.py

using uri ./{name} from root in the old version python http.server can be handled as //{name}. But due to https://github.com/python/cpython/pull/93879, it will be handled as /{name} now.

So I want to use a prefix to avoid double slashes issue.

Diff Detail

Unit TestsFailed
View All

	Time	Test
	60,350 ms	x64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases/Linux::quarantine_size_mb.cpp
	60,090 ms	x64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases/Linux::release_to_os_test.cpp
	60,110 ms	x64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases/Posix::stack-overflow.cpp
	60,150 ms	x64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases/Posix::stack-use-after-return.cpp
	60,110 ms	x64 debian > AddressSanitizer-x86_64-linux.TestCases::memset_test.cpp
		View Full Test Results (7 Failed)

Event Timeline

HerrCai0907 created this revision.Mar 13 2023, 11:34 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 11:34 PM

HerrCai0907 requested review of this revision.Mar 13 2023, 11:34 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 11:34 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B219255: Diff 504951.Mar 14 2023, 12:20 AM

I guess ut failed is not related with this PR?

HerrCai0907 added a reviewer: klimek.Mar 14 2023, 4:26 PM

rebase to main

Harbormaster completed remote builds in B219538: Diff 505355.Mar 14 2023, 9:47 PM

HerrCai0907 added a reviewer: lattner.Mar 16 2023, 5:50 AM

this motivation makes sense to me, but I'm not a competent reviewer for this area

This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2023, 6:10 AM

Closed by commit rGfb066c4622c8: [sancov] fix coverage-report-server cannot display coverage detail (authored by HerrCai0907). · Explain Why

This revision was automatically updated to reflect the committed changes.

HerrCai0907 added a commit: rGfb066c4622c8: [sancov] fix coverage-report-server cannot display coverage detail.

Revision Contents
Changeset List

Path

Size

llvm/

tools/

sancov/

coverage-report-server.py

7 lines

Diff 504951

llvm/tools/sancov/coverage-report-server.py

Loading...