This is an archive of the discontinued LLVM Phabricator instance.

Differential D145822

[HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests
ClosedPublic

Authored by kstoimenov on Mar 10 2023, 12:03 PM.

Details

Reviewers
vitalybuka
Commits
rG100a3c397c20: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests
Summary

This is a reland of a single file from D145727, which was reverted in 25ba9dcf1807. This test is using exact line number in the checks so if anything is rearranged the test fails. Moving hwasan on the same line fixes that issue.

Diff Detail

Event Timeline

kstoimenov created this revision.Mar 10 2023, 12:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2023, 12:03 PM
Herald added a subscriber: arphaman. · View Herald Transcript
kstoimenov requested review of this revision.Mar 10 2023, 12:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2023, 12:03 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
kstoimenov edited the summary of this revision. (Show Details)Mar 10 2023, 12:04 PM
kstoimenov added a reviewer: vitalybuka.
vitalybuka added inline comments.Mar 10 2023, 12:22 PM
clang/test/Index/crash-recovery-modules.m
14

// UNSUPPORTED: libstdcxx-safe-mode, hwasan

vitalybuka added a comment.Mar 10 2023, 12:22 PM

what is about detect_leaks?

kstoimenov updated this revision to Diff 504264.Mar 10 2023, 1:04 PM
kstoimenov edited the summary of this revision. (Show Details)

Moved UNSUPPORTED to one line.

kstoimenov marked an inline comment as done.Mar 10 2023, 1:06 PM
In D145822#4185801, @vitalybuka wrote:

what is about detect_leaks?

Yes. I had to revert only this file because it broke a bunch of bots.

Harbormaster completed remote builds in B218763: Diff 504264.Mar 10 2023, 3:34 PM
vitalybuka accepted this revision.Mar 10 2023, 4:06 PM
This revision is now accepted and ready to land.Mar 10 2023, 4:06 PM
kstoimenov edited the summary of this revision. (Show Details)Mar 10 2023, 4:13 PM
Closed by commit rG100a3c397c20: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests (authored by kstoimenov). · Explain WhyMar 10 2023, 4:14 PM
This revision was automatically updated to reflect the committed changes.
kstoimenov added a commit: rG100a3c397c20: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests.

Revision Contents

PathSize
clang/
test/
Index/
1 line

Diff 504244

clang/test/Index/crash-recovery-modules.m

// Clear out the module cache entirely, so we start from nothing. // Clear out the module cache entirely, so we start from nothing.
// RUN: rm -rf %t // RUN: rm -rf %t
// Parse the file, such that building the module will cause Clang to crash. // Parse the file, such that building the module will cause Clang to crash.
// RUN: env CINDEXTEST_FAILONERROR=1 not c-index-test -test-load-source all -fmodules -fmodules-cache-path=%t -Xclang -fdisable-module-hash -I %S/Inputs/Headers -DCRASH %s > /dev/null 2> %t.err // RUN: env CINDEXTEST_FAILONERROR=1 not c-index-test -test-load-source all -fmodules -fmodules-cache-path=%t -Xclang -fdisable-module-hash -I %S/Inputs/Headers -DCRASH %s > /dev/null 2> %t.err
// RUN: FileCheck < %t.err -check-prefix=CHECK-CRASH %s // RUN: FileCheck < %t.err -check-prefix=CHECK-CRASH %s
// CHECK-CRASH: crash-recovery-modules.m:16:9:{16:2-16:14}: fatal error: could not build module 'Crash' // CHECK-CRASH: crash-recovery-modules.m:16:9:{16:2-16:14}: fatal error: could not build module 'Crash'
// Parse the file again, without crashing, to make sure that // Parse the file again, without crashing, to make sure that
// subsequent parses do the right thing. // subsequent parses do the right thing.
// RUN: env CINDEXTEST_FAILONERROR=1 c-index-test -test-load-source all -fmodules -fmodules-cache-path=%t -Xclang -fdisable-module-hash -I %S/Inputs/Headers %s > /dev/null // RUN: env CINDEXTEST_FAILONERROR=1 c-index-test -test-load-source all -fmodules -fmodules-cache-path=%t -Xclang -fdisable-module-hash -I %S/Inputs/Headers %s > /dev/null
// REQUIRES: crash-recovery // REQUIRES: crash-recovery
// UNSUPPORTED: libstdcxx-safe-mode // UNSUPPORTED: libstdcxx-safe-mode
vitalybukaUnsubmitted
Done
ReplyInline Actions

// UNSUPPORTED: libstdcxx-safe-mode, hwasan

vitalybuka: // UNSUPPORTED: libstdcxx-safe-mode, hwasan
@import Crash; @import Crash;
#ifdef LIBCLANG_CRASH #ifdef LIBCLANG_CRASH
#pragma clang __debug crash #pragma clang __debug crash
#endif #endif
void test(void) { void test(void) {
const char* error = getCrashString(); const char* error = getCrashString();
} }
// RUN: rm -rf %t // RUN: rm -rf %t
// Check that libclang crash-recovery works; both with a module building crash... // Check that libclang crash-recovery works; both with a module building crash...
// RUN: env CINDEXTEST_FAILONERROR=1 not c-index-test -test-load-source all -fmodules -fmodules-cache-path=%t -Xclang -fdisable-module-hash -I %S/Inputs/Headers -DCRASH -DLIBCLANG_CRASH %s > /dev/null 2> %t.err // RUN: env CINDEXTEST_FAILONERROR=1 not c-index-test -test-load-source all -fmodules -fmodules-cache-path=%t -Xclang -fdisable-module-hash -I %S/Inputs/Headers -DCRASH -DLIBCLANG_CRASH %s > /dev/null 2> %t.err
// RUN: FileCheck < %t.err -check-prefix=CHECK-LIBCLANG-CRASH %s // RUN: FileCheck < %t.err -check-prefix=CHECK-LIBCLANG-CRASH %s
// ...and with module building successful. // ...and with module building successful.
// RUN: env CINDEXTEST_FAILONERROR=1 not c-index-test -test-load-source all -fmodules -fmodules-cache-path=%t -Xclang -fdisable-module-hash -I %S/Inputs/Headers -DLIBCLANG_CRASH %s > /dev/null 2> %t.err // RUN: env CINDEXTEST_FAILONERROR=1 not c-index-test -test-load-source all -fmodules -fmodules-cache-path=%t -Xclang -fdisable-module-hash -I %S/Inputs/Headers -DLIBCLANG_CRASH %s > /dev/null 2> %t.err
// RUN: FileCheck < %t.err -check-prefix=CHECK-LIBCLANG-CRASH %s // RUN: FileCheck < %t.err -check-prefix=CHECK-LIBCLANG-CRASH %s
// CHECK-LIBCLANG-CRASH-DAG: libclang: crash detected during parsing // CHECK-LIBCLANG-CRASH-DAG: libclang: crash detected during parsing
// CHECK-LIBCLANG-CRASH-DAG: Unable to load translation unit! // CHECK-LIBCLANG-CRASH-DAG: Unable to load translation unit!
// UNSUPPORTED: hwasan