This is an archive of the discontinued LLVM Phabricator instance.

[HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests
ClosedPublic

Authored by kstoimenov on Mar 10 2023, 12:03 PM.

Details

Summary

This is a reland of a single file from D145727, which was reverted in 25ba9dcf1807. This test is using exact line number in the checks so if anything is rearranged the test fails. Moving hwasan on the same line fixes that issue.

Diff Detail

Event Timeline

kstoimenov created this revision.Mar 10 2023, 12:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2023, 12:03 PM
Herald added a subscriber: arphaman. · View Herald Transcript
kstoimenov requested review of this revision.Mar 10 2023, 12:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2023, 12:03 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
kstoimenov edited the summary of this revision. (Show Details)Mar 10 2023, 12:04 PM
kstoimenov added a reviewer: vitalybuka.
vitalybuka added inline comments.Mar 10 2023, 12:22 PM
clang/test/Index/crash-recovery-modules.m
14

// UNSUPPORTED: libstdcxx-safe-mode, hwasan

what is about detect_leaks?

kstoimenov edited the summary of this revision. (Show Details)

Moved UNSUPPORTED to one line.

kstoimenov marked an inline comment as done.Mar 10 2023, 1:06 PM

what is about detect_leaks?

Yes. I had to revert only this file because it broke a bunch of bots.

vitalybuka accepted this revision.Mar 10 2023, 4:06 PM
This revision is now accepted and ready to land.Mar 10 2023, 4:06 PM
kstoimenov edited the summary of this revision. (Show Details)Mar 10 2023, 4:13 PM