[ORC] Fix name shadowing issue, NFC.

[bzcheeseman]

Summary

Testing the COFFPlatform on MSVC, a name shadowing issue surfaced where LoadDynLibrary inside the constructor was actually using the moved-from function argument. This patch simply renames the argument to avoid that shadowing.

[lhames]

Hi Aman,

This change looks fine, however naming the constructor argument for the member variable is idiomatic in ORC (and common elsewhere in LLVM from memory), and something like this should usually be resolved by explicitly specifying this->. Ideally constructor bodies should be small enough to spot bugs like this easily, but that's not the case here -- we should probably try to break this constructor body out into a separate method (which has the advantage of simplifying error returns too).

• Lang.

llvm/include/llvm/ExecutionEngine/Orc/COFFPlatform.h

struct JDBootstrapState {
     std::list<COFFObjectSectionsMap> ObjectSectionsMaps;
     SmallVector<std::pair<std::string, ExecutorAddr>> Initializers;
   };
 
   static bool supportedTarget(const Triple &TT);
 
   COFFPlatform(ExecutionSession &ES, ObjectLinkingLayer &ObjLinkingLayer,
                JITDylib &PlatformJD, const char *OrcRuntimePath,
-               LoadDynamicLibrary LoadDynLibrary, bool StaticVCRuntime,
+               LoadDynamicLibrary LoadDynamicLibrary, bool StaticVCRuntime,
                const char *VCRuntimePath, Error &Err);
 
   // Associate COFFPlatform JIT-side runtime support functions with handlers.
   Error associateRuntimeSupportFunctions(JITDylib &PlatformJD);
 
   // Records the addresses of runtime symbols used by the platform.
   Error bootstrapCOFFRuntime(JITDylib &PlatformJD);
 

llvm/lib/ExecutionEngine/Orc/COFFPlatform.cpp

bool COFFPlatform::supportedTarget(const Triple &TT) {
   default:
     return false;
   }
 }
 
 COFFPlatform::COFFPlatform(ExecutionSession &ES,
                            ObjectLinkingLayer &ObjLinkingLayer,
                            JITDylib &PlatformJD, const char *OrcRuntimePath,
-                           LoadDynamicLibrary LoadDynLibrary,
+                           LoadDynamicLibrary LoadDynamicLibrary,
                            bool StaticVCRuntime, const char *VCRuntimePath,
                            Error &Err)
     : ES(ES), ObjLinkingLayer(ObjLinkingLayer),
-      LoadDynLibrary(std::move(LoadDynLibrary)),
+      LoadDynLibrary(std::move(LoadDynamicLibrary)),
       StaticVCRuntime(StaticVCRuntime),
       COFFHeaderStartSymbol(ES.intern("__ImageBase")) {
   ErrorAsOutParameter _(&Err);
 
   // Create a generator for the ORC runtime archive.
   auto OrcRuntimeArchiveGenerator =
       StaticLibraryDefinitionGenerator::Load(ObjLinkingLayer, OrcRuntimePath);
   if (!OrcRuntimeArchiveGenerator) {