Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D145252

RegAllocFast: Fix dropping subreg indexes on unassigned subreg defs
ClosedPublic
Actions

Authored by arsenm on Mar 3 2023, 9:20 AM.

Details

Reviewers
qcolombet
MatzeB
kparzysz
Summary

This was assuming all register operands were assigned to physical registers.
This should ignore the operands which weren't assigned in this run.




Fixes #61134
Diff Detail
Event Timeline
arsenm created this revision.Mar 3 2023, 9:20 AM
Herald added a project: Restricted Project.  ·  View Herald TranscriptMar 3 2023, 9:20 AM
Herald added subscribers: kosarev, kerbowa, arphaman and 2 others.  ·  View Herald Transcript
arsenm requested review of this revision.Mar 3 2023, 9:20 AM
Herald added a project: Restricted Project.  ·  View Herald TranscriptMar 3 2023, 9:20 AM
Herald added a subscriber: wdng.  ·  View Herald Transcript
Harbormaster completed remote builds in B217191: Diff 502157.Mar 3 2023, 10:49 AM
arsenm added a comment.Mar 26 2023, 6:40 AM
ping
qcolombet accepted this revision.Apr 4 2023, 7:06 AM
Nice catch!



Just one comment: Could you rename the filename of the added test case with something more explanatory? (E.g., regalloc-fast-dont-drop-subreg-index.mir)
This revision is now accepted and ready to land.Apr 4 2023, 7:06 AM
arsenm closed this revision.Apr 5 2023, 3:26 PM
7907fd49619f121df6feafd8ca524840bcb6d5da
Revision Contents
Changeset List
PathSize
llvm/
lib/
CodeGen/
5 lines
test/
CodeGen/
AMDGPU/
39 lines
Diff 502157
View Options
llvm/lib/CodeGen/RegAllocFast.cpp
Loading...
View Options
llvm/test/CodeGen/AMDGPU/issue61134.mir
Loading...