The config is based on the ARM MacOS config, but with fenv and math
functions disabled.
This should unblock this bug: https://github.com/llvm/llvm-project/issues/60910
Paths
| Differential D145099
[libc] add basic Intel MacOS configuration ClosedPublic Authored by michaelrj on Mar 1 2023, 11:39 AM.
Details
Summary The config is based on the ARM MacOS config, but with fenv and math This should unblock this bug: https://github.com/llvm/llvm-project/issues/60910
Diff Detail
Event TimelineHerald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 1 2023, 11:39 AM Herald added subscribers: libc-commits, ecnelises, tschuett, kristof.beyls. · View Herald Transcript
Comment Actions add comment explaining the fenv condition
sivachandra added inline comments.
This revision is now accepted and ready to land.Mar 1 2023, 3:01 PM This revision was landed with ongoing or failed builds.Mar 1 2023, 3:33 PM Closed by commit rGeffd56b0a030: [libc] add basic Intel MacOS configuration (authored by michaelrj). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 501685 libc/config/darwin/x86_64/entrypoints.txt
libc/config/darwin/x86_64/headers.txt
libc/src/__support/FPUtil/FEnvImpl.h
|
The !defined(__APPLE__) above and this condition here are opposites? Irrespective, can we use a model like the AARCH64 one?