This is an archive of the discontinued LLVM Phabricator instance.

[libc] Fix strcspn
ClosedPublic

Authored by abrachet on Feb 28 2023, 11:41 AM.

Diff Detail

Event Timeline

abrachet created this revision.Feb 28 2023, 11:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 11:41 AM
abrachet requested review of this revision.Feb 28 2023, 11:41 AM
sivachandra accepted this revision.Feb 28 2023, 11:55 AM
sivachandra added inline comments.
libc/src/string/string_utils.h
169–171

I am guessing that you are seeing a signed vs unsigned problem? If yes, then may be *reinterpret_cast<const unsigned char *>(segment) ?

This revision is now accepted and ready to land.Feb 28 2023, 11:55 AM
This revision was landed with ongoing or failed builds.Mar 1 2023, 10:58 AM
Closed by commit rGc891ef6ca014: [libc] Fix strcspn (authored by abrachet). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 10:58 AM
abrachet marked an inline comment as done.Mar 1 2023, 10:58 AM
abrachet added inline comments.
libc/src/string/string_utils.h
169–171

Done in commit