This is an archive of the discontinued LLVM Phabricator instance.

[Dexter] Add target_run_args option
ClosedPublic

Authored by StephenTozer on Feb 28 2023, 9:39 AM.

Details

Summary

Adds an option to Dexter that passes command line arguments to the debugged process, following (and in addition to) any arguments given by the DexCommandLine command.

Diff Detail

Event Timeline

StephenTozer created this revision.Feb 28 2023, 9:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 9:39 AM
StephenTozer requested review of this revision.Feb 28 2023, 9:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 9:39 AM

LGTM with test suggestion inline

cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test/target_run_args.c
6

Please can we have a DexCommandLine command in here too to test that the features compose?

Added a test to check that --target-run-args and DexCommandLine compose - needs to be a separate test file because of a few necessary differences in the file, which can't be fixed by using sed in the RUN line.

Orlando accepted this revision.Mar 15 2023, 7:45 AM

New test LGTM, thanks

This revision is now accepted and ready to land.Mar 15 2023, 7:45 AM
This revision was automatically updated to reflect the committed changes.