This is an archive of the discontinued LLVM Phabricator instance.

[X86] Add DwarfRegNums for segment registers
ClosedPublic

Authored by abrachet on Feb 27 2023, 11:20 AM.

Diff Detail

Event Timeline

abrachet created this revision.Feb 27 2023, 11:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2023, 11:20 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
abrachet requested review of this revision.Feb 27 2023, 11:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2023, 11:20 AM

Needs a test case.

mcgrathr added inline comments.Feb 27 2023, 11:33 AM
llvm/lib/Target/X86/X86RegisterInfo.td
323

The comment above says this should be: [x86-64, x86-32 Darwin EH, generic x86-32].
So I think the -2 case is the middle one not the third one.

abrachet updated this revision to Diff 500877.Feb 27 2023, 12:34 PM
abrachet marked an inline comment as done.
abrachet added inline comments.
llvm/lib/Target/X86/X86RegisterInfo.td
323

Good catch, I had remembered this the other way around.

This revision is now accepted and ready to land.Feb 27 2023, 1:55 PM
This revision was automatically updated to reflect the committed changes.
abrachet marked an inline comment as done.