This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Add primitive builders for scf.if
ClosedPublic

Authored by frgossen on Feb 27 2023, 8:49 AM.

Diff Detail

Event Timeline

frgossen created this revision.Feb 27 2023, 8:49 AM
frgossen requested review of this revision.Feb 27 2023, 8:49 AM
jpienaar accepted this revision.Feb 27 2023, 10:12 AM

Nit: commit message. The rest looks fine (I forget if we allowed default values in OpBuilder ... )

This revision is now accepted and ready to land.Feb 27 2023, 10:12 AM
frgossen retitled this revision from BEGIN_PUBLIC [MLIR] Add primitive builders for scf.if END_PUBLIC to [MLIR] Add primitive builders for scf.if.Feb 27 2023, 10:52 AM

Thanks! Default values are possible but then it collides with the other builder

This revision was automatically updated to reflect the committed changes.