Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Nit: commit message. The rest looks fine (I forget if we allowed default values in OpBuilder ... )
Paths
| Differential D144886
[MLIR] Add primitive builders for scf.if ClosedPublic Authored by frgossen on Feb 27 2023, 8:49 AM.
Details
Diff Detail
Event TimelineComment Actions Nit: commit message. The rest looks fine (I forget if we allowed default values in OpBuilder ... ) This revision is now accepted and ready to land.Feb 27 2023, 10:12 AM frgossen retitled this revision from BEGIN_PUBLIC [MLIR] Add primitive builders for scf.if END_PUBLIC to [MLIR] Add primitive builders for scf.if.Feb 27 2023, 10:52 AM Comment ActionsThanks! Default values are possible but then it collides with the other builder Closed by commit rGe7b52c46bf31: [MLIR] Add primitive builders for scf.if (authored by frgossen). · Explain WhyFeb 27 2023, 10:54 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 500849 mlir/include/mlir/Dialect/SCF/IR/SCFOps.td
mlir/lib/Dialect/SCF/IR/SCF.cpp
|