This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Improves clang-format settings.
ClosedPublic

Authored by Mordante on Feb 24 2023, 12:41 PM.

Details

Summary

Add a new test based .clang-format file which inherits from the generic
one. This moves some test specific formatting rules to the test
directory.

The main benefit is that headers are sorted, which makes it more likely
to catch these errors before creating a review instead of spotting the
error in the CI clang-tidy step.

Diff Detail

Event Timeline

Mordante created this revision.Feb 24 2023, 12:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2023, 12:41 PM
Mordante requested review of this revision.Feb 24 2023, 12:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2023, 12:41 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante updated this revision to Diff 500418.Feb 25 2023, 5:06 AM

Update formatting.

philnik accepted this revision as: philnik.Feb 25 2023, 5:09 AM
Mordante updated this revision to Diff 500422.Feb 25 2023, 5:21 AM

CI fixes.

ldionne accepted this revision.Feb 27 2023, 10:13 AM

Nice improvement!

This revision is now accepted and ready to land.Feb 27 2023, 10:13 AM
This revision was automatically updated to reflect the committed changes.