This is an archive of the discontinued LLVM Phabricator instance.

[libc++][test] Silence MSVC deprecation warnings
ClosedPublic

Authored by CaseyCarter on Feb 23 2023, 6:50 PM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG7d5275e0c0e4: [libc++][test] Silence MSVC deprecation warnings
Summary

... for implicitly-generated copy constructors and copy assignment operators.

Diff Detail

Event Timeline

CaseyCarter created this revision.Feb 23 2023, 6:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 6:50 PM
CaseyCarter requested review of this revision.Feb 23 2023, 6:50 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptFeb 23 2023, 6:50 PM
Mordante accepted this revision.Feb 24 2023, 8:12 AM
Mordante added a subscriber: Mordante.

Thanks, LGTM!

This revision is now accepted and ready to land.Feb 24 2023, 8:12 AM

I think clang also has a deprecation flag for this. Please enable it, so we don't regress.

fsb4000 added a subscriber: fsb4000.EditedFeb 24 2023, 7:57 PM

Thanks @philnik , I found the warning: -Wdeprecated-copy-with-user-provided-dtor: https://godbolt.org/z/rr186sGYK

Oh, I read https://github.com/llvm/llvm-project/issues/60977 and check that -Wdeprecated also works.

This revision was automatically updated to reflect the committed changes.