This is an archive of the discontinued LLVM Phabricator instance.

Differential D144684

[clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address
ClosedPublic

Authored by aeubanks on Feb 23 2023, 4:20 PM.

Details

Reviewers
hans
thakis
Commits
rGdc07867dc999: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address
Summary

With recent MSVC releases, STL headers will add /INFERASANLIBS to the drectve section of object files that are compiled with clang. With this flag, link.exe will automatically attempt to look for asan libs.

When using clang as the driver to invoke the linker, we want to disable this feature because we explicitly pass the proper asan libraries, otherwise we get symbols defined multiple times.

Diff Detail

Unit TestsFailed

TimeTest
140 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/ranges/range_adaptors/range_all::all.nodiscard.verify.cpp
140 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/ranges/range_adaptors/range_common_view::adaptor.nodiscard.verify.cpp
170 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/ranges/range_adaptors/range_reverse::adaptor.nodiscard.verify.cpp
260 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/ranges/range_adaptors/range_transform::adaptor.nodiscard.verify.cpp
1,290 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.std/algorithms/alg_modifying_operations/alg_copy::ranges.copy.segmented.pass.cpp
View Full Test Results (22 Failed)

Event Timeline

aeubanks created this revision.Feb 23 2023, 4:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 4:20 PM
aeubanks requested review of this revision.Feb 23 2023, 4:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 4:20 PM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B215620: Diff 500009.Feb 23 2023, 5:00 PM
hans accepted this revision.Feb 24 2023, 5:00 AM

lgtm

This revision is now accepted and ready to land.Feb 24 2023, 5:00 AM
This revision was landed with ongoing or failed builds.Feb 24 2023, 9:35 AM
Closed by commit rGdc07867dc999: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGdc07867dc999: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address.

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
5 lines
test/
Driver/
8 lines

Diff 500009

clang/lib/Driver/ToolChains/MSVC.cpp

Show First 20 Lines • Show All 330 Lines • ▼ Show 20 Lines if (!TC.FoundMSVCInstall() && !canExecute(TC.getVFS(), linkPath)) {
llvm::sys::path::append(linkPath, "link.exe"); llvm::sys::path::append(linkPath, "link.exe");
if (!canExecute(TC.getVFS(), linkPath)) if (!canExecute(TC.getVFS(), linkPath))
C.getDriver().Diag(clang::diag::warn_drv_msvc_not_found); C.getDriver().Diag(clang::diag::warn_drv_msvc_not_found);
} else { } else {
C.getDriver().Diag(clang::diag::warn_drv_msvc_not_found); C.getDriver().Diag(clang::diag::warn_drv_msvc_not_found);
} }
} }
// Clang handles passing the proper asan libs to the linker, which goes
// against link.exe's /INFERASANLIBS which automatically finds asan libs.
if (TC.getSanitizerArgs(Args).needsAsanRt())
CmdArgs.push_back("/INFERASANLIBS:NO");
#ifdef _WIN32 #ifdef _WIN32
// When cross-compiling with VS2017 or newer, link.exe expects to have // When cross-compiling with VS2017 or newer, link.exe expects to have
// its containing bin directory at the top of PATH, followed by the // its containing bin directory at the top of PATH, followed by the
// native target bin directory. // native target bin directory.
// e.g. when compiling for x86 on an x64 host, PATH should start with: // e.g. when compiling for x86 on an x64 host, PATH should start with:
// /bin/Hostx64/x86;/bin/Hostx64/x64 // /bin/Hostx64/x86;/bin/Hostx64/x64
// This doesn't attempt to handle llvm::ToolsetLayout::DevDivInternal. // This doesn't attempt to handle llvm::ToolsetLayout::DevDivInternal.
if (TC.getIsVS2017OrNewer() && if (TC.getIsVS2017OrNewer() &&
▲ Show 20 Lines • Show All 650 Lines • Show Last 20 Lines

clang/test/Driver/cl-link.c

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
// RUN: %clang_cl /Tc%s nonexistent.obj -fuse-ld=link -### 2>&1 | FileCheck --check-prefix=NONEXISTENT %s // RUN: %clang_cl /Tc%s nonexistent.obj -fuse-ld=link -### 2>&1 | FileCheck --check-prefix=NONEXISTENT %s
// RUN: %clang_cl /Tc%s nonexistent.lib -fuse-ld=link -### 2>&1 | FileCheck --check-prefix=NONEXISTENT %s // RUN: %clang_cl /Tc%s nonexistent.lib -fuse-ld=link -### 2>&1 | FileCheck --check-prefix=NONEXISTENT %s
// NONEXISTENT-NOT: no such file // NONEXISTENT-NOT: no such file
// NONEXISTENT: link.exe // NONEXISTENT: link.exe
// NONEXISTENT: nonexistent // NONEXISTENT: nonexistent
// RUN: %clang_cl /Tc%s -fuse-ld=lld -### 2>&1 | FileCheck --check-prefix=USE_LLD %s // RUN: %clang_cl /Tc%s -fuse-ld=lld -### 2>&1 | FileCheck --check-prefix=USE_LLD %s
// USE_LLD: lld-link // USE_LLD: lld-link
// RUN: %clang_cl -m32 -arch:IA32 --target=i386-pc-win32 /Tc%s -fuse-ld=link -### -fsanitize=address 2>&1 | FileCheck --check-prefix=INFER-LINK %s
// INFER-LINK: link.exe
// INFER-LINK: /INFERASANLIBS:NO
// RUN: %clang_cl -m32 -arch:IA32 --target=i386-pc-win32 /Tc%s -fuse-ld=lld -### -fsanitize=address 2>&1 | FileCheck --check-prefix=INFER-LLD %s
// INFER-LLD: lld-link
// INFER-LLD-NOT: INFERASANLIBS