This is an archive of the discontinued LLVM Phabricator instance.

[X86] Move atomics test for !pcsections into separate file
ClosedPublic

Authored by melver on Feb 23 2023, 2:42 PM.

Details

Summary

The pcsections.ll test primarily tests that the AsmPrinter produces the
right output in sections. This output is not easily covered by
update_llc_test_checks.py, and as such is hand written. This makes
maintenance rather burdensome. Instead, let's keep pcsections.ll as
simple as possible.

Move the more complex tests that primarily test that some atomic
operations end up in the PC section to pcsections-atomics.ll.

NFC.

Diff Detail

Unit TestsFailed

Event Timeline

melver created this revision.Feb 23 2023, 2:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 2:42 PM
Herald added a subscriber: pengfei. · View Herald Transcript
melver requested review of this revision.Feb 23 2023, 2:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 2:42 PM
dvyukov accepted this revision.Feb 23 2023, 10:55 PM
This revision is now accepted and ready to land.Feb 23 2023, 10:55 PM
vitalybuka accepted this revision.Feb 23 2023, 11:00 PM

I'd recommend move in one patch and update in another

melver updated this revision to Diff 500106.Feb 24 2023, 1:35 AM
melver edited the summary of this revision. (Show Details)

Move existing tests only.

This revision was automatically updated to reflect the committed changes.