This is an archive of the discontinued LLVM Phabricator instance.

[MC][nfc] Don't use a value after it has been std::move()'d
ClosedPublic

Authored by int3 on Feb 23 2023, 11:28 AM.

Diff Detail

Event Timeline

int3 created this revision.Feb 23 2023, 11:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 11:28 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
int3 requested review of this revision.Feb 23 2023, 11:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 11:28 AM

LGTM (I assume that most of the time, we're just copying pointers and it's fine either way).

This revision is now accepted and ready to land.Feb 23 2023, 11:59 AM
int3 added a comment.Feb 23 2023, 12:14 PM

It's fine because TargetMachine doesn't define a move ctor :)

This revision was landed with ongoing or failed builds.Feb 23 2023, 12:15 PM
This revision was automatically updated to reflect the committed changes.