[flang] Relax the check for polymorphic pointer in storage_size intrinsic

[clementval]

Summary

The runtime check was a too strong as the standard says.

If it is polymorphic it shall not be an undefined pointer.

The check was checking if the pointer was associated.
Remove the check as other compilers do.

Depends on D144643

[PeteSteinfeld]

All builds and tests correctly and looks good.

flang/lib/Optimizer/Builder/IntrinsicCall.cpp

IntrinsicLibrary::genStorageSize(mlir::Type resultType,
 
   if (fir::isUnlimitedPolymorphicType(boxTy) &&
       (fir::isAllocatableType(boxTy) || fir::isPointerType(boxTy))) {
     needRuntimeCheck = true;
     errorMsg =
         fir::isPointerType(boxTy)
             ? "unlimited polymorphic disassociated POINTER in STORAGE_SIZE"
             : "unlimited polymorphic unallocated ALLOCATABLE in STORAGE_SIZE";
-  } else if (fir::isPolymorphicType(boxTy) && fir::isPointerType(boxTy)) {
-    needRuntimeCheck = true;
-    errorMsg = "polymorphic disassociated POINTER in STORAGE_SIZE";
   }
   const fir::MutableBoxValue *mutBox = args[0].getBoxOf<fir::MutableBoxValue>();
   if (needRuntimeCheck && mutBox) {
     mlir::Value isNotAllocOrAssoc =
         fir::factory::genIsNotAllocatedOrAssociatedTest(builder, loc, *mutBox);
     builder.genIfThen(loc, isNotAllocOrAssoc)
         .genThen([&]() {
           fir::runtime::genReportFatalUserError(builder, loc, errorMsg);

flang/test/Lower/Intrinsics/storage_size.f90

integer function polymorphic_pointer(p) result(size)
     class(p1), pointer :: p
     size = storage_size(p)
   end function
 
 ! CHECK-LABEL: func.func @_QMstorage_size_testPpolymorphic_pointer(
 ! CHECK-SAME: %[[P:.*]]: !fir.ref<!fir.class<!fir.ptr<!fir.type<_QMstorage_size_testTp1{a:i32}>>>> {fir.bindc_name = "p"}) -> i32 {
 ! CHECK: %[[SIZE:.*]] = fir.alloca i32 {bindc_name = "size", uniq_name = "_QMstorage_size_testFpolymorphic_pointerEsize"}
 ! CHECK: %[[LOAD_P:.*]] = fir.load %[[P]] : !fir.ref<!fir.class<!fir.ptr<!fir.type<_QMstorage_size_testTp1{a:i32}>>>>
-! CHECK: %[[P_ADDR:.*]] = fir.box_addr %[[LOAD_P]] : (!fir.class<!fir.ptr<!fir.type<_QMstorage_size_testTp1{a:i32}>>>) -> !fir.ptr<!fir.type<_QMstorage_size_testTp1{a:i32}>>
-! CHECK: %[[P_ADDR_I64:.*]] = fir.convert %[[P_ADDR]] : (!fir.ptr<!fir.type<_QMstorage_size_testTp1{a:i32}>>) -> i64
-! CHECK: %[[C0:.*]] = arith.constant 0 : i64
-! CHECK: %[[IS_NULL_ADDR:.*]] = arith.cmpi eq, %[[P_ADDR_I64]], %[[C0]] : i64
-! CHECK: fir.if %[[IS_NULL_ADDR]] {
-! CHECK:   %{{.*}} = fir.call @_FortranAReportFatalUserError(%{{.*}}, %{{.*}}, %{{.*}}) {{.*}} : (!fir.ref<i8>, !fir.ref<i8>, i32) -> none
-! CHECK: }
-! CHECK: %[[LOAD_P:.*]] = fir.load %[[P]] : !fir.ref<!fir.class<!fir.ptr<!fir.type<_QMstorage_size_testTp1{a:i32}>>>>
 ! CHECK: %[[ELE_SIZE:.*]] = fir.box_elesize %[[LOAD_P]] : (!fir.class<!fir.ptr<!fir.type<_QMstorage_size_testTp1{a:i32}>>>) -> i32
 ! CHECK: %[[C8:.*]] = arith.constant 8 : i32
 ! CHECK: %[[BITS:.*]] = arith.muli %[[ELE_SIZE]], %[[C8]] : i32
 ! CHECK: fir.store %[[BITS]] to %[[SIZE]] : !fir.ref<i32>
 ! CHECK: %[[RES:.*]] = fir.load %[[SIZE]] : !fir.ref<i32>
 ! CHECK: return %[[RES]] : i32
 
   integer function polymorphic(p) result(size)