This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Split modules_include test to reduce overall runtime
AbandonedPublic

Authored by DavidSpickett on Feb 23 2023, 3:08 AM.

Details

Reviewers
ldionne
Mordante
philnik
Group Reviewers
Restricted Project
Summary

This test was taking around 20-25 minutes to complete on Arm 32 bit.
https://reviews.llvm.org/D144259 appears to have increased that even
more which pushed us over the 25 minute timeout for CI.

Even on AArch64 the test took 18 minutes and it took 14 minutes on
the generic clang-15 bot.

I've split the test into 4 parts to bring it down to about 5 minutes
per test on Arm 32.

We could split it further but at that point we should be looking
at generating the whole set of files instead.

Diff Detail

Event Timeline

DavidSpickett created this revision.Feb 23 2023, 3:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 3:08 AM
DavidSpickett requested review of this revision.Feb 23 2023, 3:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 3:08 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
DavidSpickett added inline comments.
libcxx/test/libcxx/modules_include_1.sh.cpp
39

// otherwise you get a float, and you can't slice with a float.

59

If we want these numbers to still match the index of the header in public_headers, that can be arranged.