This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Improve LIT tests on composite target constructs
ClosedPublic

Authored by animeshk-amd on Feb 22 2023, 1:43 AM.

Details

Summary

This commit improves the "target_teams_distribute_paralle
l_for_simd_codegen.cpp" and "target_teams_distribute_redu
ction_codegen.cpp" tests based upon some of the execution
tests present in the SOLLVE tests. Based on SOLLVE, a new
test "target_task_affinity_codegen.cpp" is also being
added. These tests are required to be added because the
existing tests do not test the combination of directives
these will be testing.

Link to SOLLVE page: https://github.com/SOLLVE/sollve_vv

Diff Detail

Unit TestsFailed

Event Timeline

animeshk-amd created this revision.Feb 22 2023, 1:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2023, 1:43 AM
animeshk-amd requested review of this revision.Feb 22 2023, 1:43 AM
Herald added a project: Restricted Project. · View Herald Transcript
jdoerfert accepted this revision.Feb 22 2023, 7:32 AM

I guess this is fine. We should try to run V&V tests, this is really just checking if we generate (some) code.

This revision is now accepted and ready to land.Feb 22 2023, 7:32 AM

Removed a pragma line which was not required.

This revision was landed with ongoing or failed builds.Feb 22 2023, 8:58 PM
This revision was automatically updated to reflect the committed changes.

I guess this is fine. We should try to run V&V tests, this is really just checking if we generate (some) code.

Thanks for accepting.
Right. By running V&V tests, do you mean to suggest that these combinations of directives should instead be tested using execution tests which are usually run using ninja check-openmp ? For example, tests in the "openmp/libomptarget/test/" directory.

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen.cpp