This is an archive of the discontinued LLVM Phabricator instance.

Differential D144527

[Test] Set gitattributes for line endings in tapi inputs
ClosedPublic

Authored by bogner on Feb 21 2023, 3:45 PM.

Details

Reviewers
ributzka
cishida
Commits
rG88bd2601c013: [Test] Set gitattributes for line endings in tapi inputs
Summary

LLVM's parsing of .tbd files errors out with "unsupported file type"
if the tbd files have CRLF line endings. Add gitattributes for the
inputs to avoid test failures on windows.

Diff Detail

Event Timeline

bogner created this revision.Feb 21 2023, 3:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 3:45 PM
Herald added subscribers: jdoerfert, mcrosier. · View Herald Transcript
bogner requested review of this revision.Feb 21 2023, 3:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 3:45 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
cishida accepted this revision.Feb 21 2023, 3:47 PM

LGTM, thank you!

This revision is now accepted and ready to land.Feb 21 2023, 3:47 PM
This revision was landed with ongoing or failed builds.Feb 21 2023, 4:07 PM
Closed by commit rG88bd2601c013: [Test] Set gitattributes for line endings in tapi inputs (authored by bogner). · Explain Why
This revision was automatically updated to reflect the committed changes.
bogner added a commit: rG88bd2601c013: [Test] Set gitattributes for line endings in tapi inputs.
Harbormaster completed remote builds in B215124: Diff 499317.Feb 21 2023, 5:04 PM

Revision Contents

PathSize
llvm/
2 lines

Diff 499319

llvm/.gitattributes

Show All 16 Lines
test/YAMLParser/spec-09-02.test binary test/YAMLParser/spec-09-02.test binary
# These files must have CRLF line endings, therefore git should explicity treat # These files must have CRLF line endings, therefore git should explicity treat
# them as always having crlf line endings # them as always having crlf line endings
test/MC/AsmParser/preserve-comments-crlf.s text eol=crlf test/MC/AsmParser/preserve-comments-crlf.s text eol=crlf
test/tools/llvm-mca/X86/directives-handle-crlf.s text eol=crlf test/tools/llvm-mca/X86/directives-handle-crlf.s text eol=crlf
# These files must have LF line endings because the test requires exact matching # These files must have LF line endings because the test requires exact matching
test/Object/Inputs/*.tbd eol=lf
test/tools/llvm-strings/radix.test text eol=lf test/tools/llvm-strings/radix.test text eol=lf
test/tools/llvm-tapi-diff/Inputs/*.tbd text eol=lf
test/tools/split-file/basic.test text eol=lf test/tools/split-file/basic.test text eol=lf
test/tools/split-file/Inputs/basic-*.txt eol=lf test/tools/split-file/Inputs/basic-*.txt eol=lf
test/tools/split-file/basic.crlf.test text eol=crlf test/tools/split-file/basic.crlf.test text eol=crlf
test/tools/split-file/Inputs/basic-*.crlf eol=crlf test/tools/split-file/Inputs/basic-*.crlf eol=crlf