This is an archive of the discontinued LLVM Phabricator instance.

Use transfer by reference instead of value to make some space more efficient
AbandonedPublic

Authored by XinWang10 on Feb 20 2023, 1:29 AM.

Details

Reviewers
skan
pengfei
Summary

Some enumerate function transfer parameter by value and not by reference,
I think these members are big enough, can use reference to reduce the mem
copy.

Diff Detail

Event Timeline

XinWang10 created this revision.Feb 20 2023, 1:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 20 2023, 1:29 AM
XinWang10 requested review of this revision.Feb 20 2023, 1:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 20 2023, 1:29 AM
XinWang10 retitled this revision from use transfer by reference instead of value to make some space more efficient to Use transfer by reference instead of value to make some space more efficient.Feb 20 2023, 2:14 AM
XinWang10 edited the summary of this revision. (Show Details)
XinWang10 added reviewers: skan, pengfei.
skan requested changes to this revision.EditedFeb 20 2023, 2:30 AM

Do not use simple "I think these members are big enough". "auto" is used for type here and the concrete type is not explicit for the reviewers. Please provide more justification.

This revision now requires changes to proceed.Feb 20 2023, 2:30 AM
XinWang10 abandoned this revision.Feb 20 2023, 5:37 PM