This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Granularize <atomic> includes
ClosedPublic

Authored by philnik on Feb 17 2023, 3:55 AM.

Details

Reviewers
ldionne
Mordante
var-const
Group Reviewers
Restricted Project
Commits
rG70617a1a2389: [libc++] Granularize <atomic> includes

Diff Detail

Event Timeline

philnik created this revision.Feb 17 2023, 3:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2023, 3:55 AM
philnik requested review of this revision.Feb 17 2023, 3:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2023, 3:55 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik updated this revision to Diff 498487.Feb 17 2023, 1:07 PM

Try to fix CI

In general I like this, but I would like to see it again after the CI is green.

libcxx/include/atomic
543

Is this header still provided by one of the granularized headers?

philnik updated this revision to Diff 499468.Feb 22 2023, 6:12 AM
philnik marked an inline comment as done.

Try to fix CI

libcxx/include/atomic
543

Yes.

ldionne accepted this revision as: ldionne.Mar 6 2023, 8:58 AM

LGTM w/ passing CI.

libcxx/include/condition_variable
114

Why did you remove this one?

274

And this.

libcxx/include/ios
232

Let's keep the for __xindex_ comment, since it seems like this is only used in 1 place

philnik updated this revision to Diff 503434.Mar 8 2023, 10:15 AM
philnik marked 3 inline comments as done.

Address comments

libcxx/include/condition_variable
114

I'm not sure what happened here. Reverted.

Mordante accepted this revision.Mar 8 2023, 10:37 AM

LGTM too, I assume the final CI fixes are minor (or the current run passes).

This revision is now accepted and ready to land.Mar 8 2023, 10:37 AM
philnik updated this revision to Diff 503483.Mar 8 2023, 1:04 PM

Fix transitive includes

philnik updated this revision to Diff 503738.Mar 9 2023, 5:31 AM

Try to fix CI

philnik updated this revision to Diff 503759.Mar 9 2023, 6:52 AM

Next try

philnik updated this revision to Diff 504061.Mar 10 2023, 2:12 AM

Try to fix CI

This revision was automatically updated to reflect the committed changes.