Page MenuHomePhabricator
Differential D144164

[clang][Interp] Handle PtrMemOps
Needs ReviewPublic
Actions

Authored by tbaeder on Feb 15 2023, 11:57 PM.

Details

Reviewers
aaron.ballman
erichkeane
tahonermann
shafik
Summary

This is a result of the discussions in https://reviews.llvm.org/D141472 and https://reviews.llvm.org/D142630.

We need to consider virtual functions when calling function pointers as well.

Diff Detail

Event Timeline

tbaeder created this revision.Feb 15 2023, 11:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2023, 11:57 PM
tbaeder requested review of this revision.Feb 15 2023, 11:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2023, 11:57 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B214073: Diff 497898.Feb 15 2023, 11:58 PM
tbaeder added a comment.Mar 10 2023, 6:37 AM

Ping

tbaeder added a comment.Mar 23 2023, 12:27 AM

Ping

tbaeder added a comment.Mar 27 2023, 2:59 AM

Ping

tbaeder added a comment.Apr 4 2023, 12:32 AM

Ping

tbaeder added a comment.Apr 13 2023, 6:49 AM

Ping

tbaeder added a comment.Apr 21 2023, 2:35 AM

Ping

tbaeder added a comment.May 1 2023, 6:40 AM

Ping

tbaeder added a comment.Fri, May 12, 7:22 AM

Ping

aaron.ballman added inline comments.Wed, May 17, 4:57 AM
clang/lib/AST/Interp/Context.cpp
122

Do you have test coverage for the bound member case?

tbaeder added inline comments.Thu, Jun 1, 2:58 AM
clang/lib/AST/Interp/Context.cpp
122

I was sure I had, I added this to make some test work... but now I removed it and nothing breaks, so I guess I don't.

tbaeder updated this revision to Diff 527346.Thu, Jun 1, 2:58 AM
Harbormaster completed remote builds in B235786: Diff 527346.Thu, Jun 1, 2:59 AM

Revision Contents
Changeset List

PathSize
clang/
lib/
AST/
Interp/
9 lines
19 lines
3 lines
test/
AST/
Interp/
5 lines
49 lines

Diff 527346

View Options

clang/lib/AST/Interp/ByteCodeExprGen.cpp

Loading...
View Options

clang/lib/AST/Interp/Context.cpp

Loading...
View Options

clang/lib/AST/Interp/Interp.h

Loading...
View Options

clang/test/AST/Interp/literals.cpp

Loading...
View Options

clang/test/AST/Interp/records.cpp

Loading...