This is an archive of the discontinued LLVM Phabricator instance.

[X86] Support load/store for bf16 vector in avx
ClosedPublic

Authored by xiangzhangllvm on Feb 15 2023, 9:54 PM.

Details

Summary

This patch extend to load/stores bf16 vector in non-avx512vl case.

We supported load/stores bf16 vector in avx512vl. but load/store just store register into mem.
If we can load/store 128/256 vector, we should also support them when the vector is bf16 vector.
In fact, we shouldn't limited this in type.

Todo: These maybe more types of load/store need to extend. Anyway let's fix bf16 first, because
we meet a urgent custom bug about it.

Diff Detail

Event Timeline

xiangzhangllvm created this revision.Feb 15 2023, 9:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2023, 9:54 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
xiangzhangllvm requested review of this revision.Feb 15 2023, 9:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2023, 9:54 PM
LuoYuanke added inline comments.Feb 15 2023, 10:08 PM
llvm/test/CodeGen/X86/avx512bf16-mov.ll
37

align 16 ?

38

ditto.

LuoYuanke accepted this revision.Feb 15 2023, 10:10 PM

LGTM execpt some NIT comments.

This revision is now accepted and ready to land.Feb 15 2023, 10:10 PM
This revision was landed with ongoing or failed builds.Feb 15 2023, 10:39 PM
This revision was automatically updated to reflect the committed changes.