This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] split sparse concatenate test cases smaller ones.
ClosedPublic

Authored by Peiming on Feb 15 2023, 2:20 PM.

Diff Detail

Event Timeline

Peiming created this revision.Feb 15 2023, 2:20 PM
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Feb 15 2023, 2:20 PM
aartbik accepted this revision.Feb 15 2023, 2:27 PM
aartbik added inline comments.
mlir/test/Integration/Dialect/SparseTensor/CPU/concatenate_dim_0.mlir
74

while you are here, here and below, period at end

mlir/test/Integration/Dialect/SparseTensor/CPU/concatenate_dim_0_permute.mlir
74

while you are here, period at end everyhere

mlir/test/Integration/Dialect/SparseTensor/CPU/concatenate_dim_1.mlir
57

while you are here, typo: permutation

74

period at end

mlir/test/Integration/Dialect/SparseTensor/CPU/concatenate_dim_1_permute.mlir
57

typo: permutation

74

period at end

This revision is now accepted and ready to land.Feb 15 2023, 2:27 PM
Peiming updated this revision to Diff 497809.Feb 15 2023, 2:35 PM
Peiming marked 3 inline comments as done.

address comments.

Peiming marked 3 inline comments as done.Feb 15 2023, 2:36 PM
Peiming retitled this revision from [mlir][sparse] split sparse concatenate test cases two smaller ones. to [mlir][sparse] split sparse concatenate test cases smaller ones..Feb 15 2023, 2:41 PM
This revision was landed with ongoing or failed builds.Feb 15 2023, 2:54 PM
This revision was automatically updated to reflect the committed changes.