This is an archive of the discontinued LLVM Phabricator instance.

[Support] Make LLVM_EXTERNAL_VISIBILITY meaningful on Windows
AbandonedPublic

Authored by junaire on Feb 14 2023, 8:07 AM.

Details

Summary

Historically for some reasons LLVM_EXTERNAL_VISIBILITY is a nop on
Windows. This patchs adds support for Windows by marking that as an
alias of __declspec(dllexport).

Signed-off-by: Jun Zhang <jun@junz.org>

Diff Detail

Event Timeline

junaire created this revision.Feb 14 2023, 8:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2023, 8:07 AM
junaire requested review of this revision.Feb 14 2023, 8:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2023, 8:07 AM
junaire updated this revision to Diff 497364.Feb 14 2023, 9:33 AM

Fix the build failure

junaire abandoned this revision.Feb 14 2023, 7:04 PM

Better to keep these in clang-repl itself since things get pretty tricky when involved templates...