This is an archive of the discontinued LLVM Phabricator instance.

llvm/test/CodeGen/Generic/addr-sink-call-multi-arg.ll
2	Can we make this an `opt -codegenprepare` test instead and use update_test_checks? (Applies to the rest of this patch stack as well.)
8	`i32 *` should be `ptr` as well.

Code change LG, please address Nikita's comments before checking in the test.

This revision is now accepted and ready to land.Feb 19 2023, 11:21 PM

chill marked an inline comment as done.

chill added inline comments.

llvm/test/CodeGen/Generic/addr-sink-call-multi-arg.ll
8	Will do.

chill marked an inline comment as done.

This revision was landed with ongoing or failed builds.Mar 23 2023, 10:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

lib/

CodeGen/

3 lines

test/

CodeGen/

Generic/

34 lines

Show First 20 Lines • Show All 2,273 Lines • ▼ Show 20 Lines	bool CodeGenPrepare::optimizeCallInst(CallInst *CI, ModifyDT &ModifiedDT) {
// ensure that we can fold all uses of a potential addressing computation		// ensure that we can fold all uses of a potential addressing computation
// into their uses. TODO: generalize this to work over profiling data		// into their uses. TODO: generalize this to work over profiling data
if (CI->hasFnAttr(Attribute::Cold) && !OptSize &&		if (CI->hasFnAttr(Attribute::Cold) && !OptSize &&
!llvm::shouldOptimizeForSize(BB, PSI, BFI.get()))		!llvm::shouldOptimizeForSize(BB, PSI, BFI.get()))
for (auto &Arg : CI->args()) {		for (auto &Arg : CI->args()) {
if (!Arg->getType()->isPointerTy())		if (!Arg->getType()->isPointerTy())
continue;		continue;
unsigned AS = Arg->getType()->getPointerAddressSpace();		unsigned AS = Arg->getType()->getPointerAddressSpace();
return optimizeMemoryInst(CI, Arg, Arg->getType(), AS);		if (optimizeMemoryInst(CI, Arg, Arg->getType(), AS))
		return true;
}		}

IntrinsicInst *II = dyn_cast<IntrinsicInst>(CI);		IntrinsicInst *II = dyn_cast<IntrinsicInst>(CI);
if (II) {		if (II) {
switch (II->getIntrinsicID()) {		switch (II->getIntrinsicID()) {
default:		default:
break;		break;
case Intrinsic::assume:		case Intrinsic::assume:
▲ Show 20 Lines • Show All 6,268 Lines • Show Last 20 Lines

				; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
				; RUN: opt -S -codegenprepare < %s \| FileCheck %s
				nikicUnsubmitted Done Reply Inline Actions Can we make this an `opt -codegenprepare` test instead and use update_test_checks? (Applies to the rest of this patch stack as well.) nikic: Can we make this an `opt -codegenprepare` test instead and use update_test_checks? (Applies to…
				; REQUIRES: aarch64-registered-target

				; Check that we don't give up if unable to sink the first argument.

				target triple = "aarch64-linux"

				nikicUnsubmitted Done Reply Inline Actions `i32 ` should be `ptr` as well. nikic:* `i32 *` should be `ptr` as well.
				chillAuthorUnsubmitted Done Reply Inline Actions Will do. chill: Will do.
				declare void @f(ptr, ptr) cold

				define void @g(i1 %c1, ptr %p, i32 %i) {
				; CHECK-LABEL: @g(
				; CHECK-NEXT: entry:
				; CHECK-NEXT: [[A0:%.]] = getelementptr ptr, ptr [[P:%.]], i32 [[I:%.*]]
				; CHECK-NEXT: br i1 [[C1:%.]], label [[IF_THEN:%.]], label [[EXIT:%.*]]
				; CHECK: if.then:
				; CHECK-NEXT: [[SUNKADDR:%.*]] = getelementptr i8, ptr [[P]], i64 32
				; CHECK-NEXT: call void @f(ptr [[A0]], ptr [[SUNKADDR]])
				; CHECK-NEXT: br label [[EXIT]]
				; CHECK: exit:
				; CHECK-NEXT: ret void
				;
				entry:
				%a0 = getelementptr i32 *, ptr %p, i32 %i
				%a1 = getelementptr i32 *, ptr %p, i32 4
				br i1 %c1, label %if.then, label %exit

				if.then:
				call void @f(ptr %a0, ptr %a1)
				br label %exit

				exit:
				ret void
				}