This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Clang gives unintended warning message for 'mthumb' + M-profiles
ClosedPublic

Authored by labrinea on Nov 5 2015, 8:57 AM.

Reviewers

rengolin
cfe-commits

Commits

Summary

$ clang --target=armv7m-none-eabi -mthumb -march=armv7-m -c test.c
clang-3.8: warning: argument unused during compilation: '-mthumb'

labrinea retitled this revision from to [ARM] Clang gives unintended warning message for 'mthumb' + M-profiles.

labrinea updated this object.

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 5 2015, 9:10 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Driver/

5 lines

Show First 20 Lines • Show All 475 Lines • ▼ Show 20 Lines	if (getTriple().isOSWindows())
ThumbDefault = true;		ThumbDefault = true;
std::string ArchName;		std::string ArchName;
if (IsBigEndian)		if (IsBigEndian)
ArchName = "armeb";		ArchName = "armeb";
else		else
ArchName = "arm";		ArchName = "arm";

// Assembly files should start in ARM mode, unless arch is M-profile.		// Assembly files should start in ARM mode, unless arch is M-profile.
if (IsMProfile \|\| (InputType != types::TY_PP_Asm &&		if ((InputType != types::TY_PP_Asm && Args.hasFlag(options::OPT_mthumb,
Args.hasFlag(options::OPT_mthumb, options::OPT_mno_thumb, ThumbDefault)))		options::OPT_mno_thumb, ThumbDefault)) \|\| IsMProfile) {
{
if (IsBigEndian)		if (IsBigEndian)
ArchName = "thumbeb";		ArchName = "thumbeb";
else		else
ArchName = "thumb";		ArchName = "thumb";
}		}
Triple.setArchName(ArchName + Suffix.str());		Triple.setArchName(ArchName + Suffix.str());

return Triple.getTriple();		return Triple.getTriple();
▲ Show 20 Lines • Show All 166 Lines • Show Last 20 Lines