Page MenuHomePhabricator

labrinea (Alexandros Lamprineas)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2015, 2:25 AM (406 w, 2 d)

Recent Activity

Yesterday

labrinea added a comment to D146158: [FuncSpec] Track the return values of specializations..

ping

Thu, Mar 23, 11:35 AM · Restricted Project, Restricted Project
labrinea updated the diff for D145379: [FuncSpec] Cost model improvements..
Thu, Mar 23, 11:33 AM · Restricted Project, Restricted Project
labrinea added inline comments to D145379: [FuncSpec] Cost model improvements..
Thu, Mar 23, 10:30 AM · Restricted Project, Restricted Project
labrinea updated the diff for D146158: [FuncSpec] Track the return values of specializations..

I found a bug in the previosu revision. When invalidating return instructions we shouldn't be looking for their lattice state in the value map, but in the tracked returns map instead. Then we should invalidate the users of the function which corresponds to that return instruction. I've changed the unit test to verify this scenario.

Thu, Mar 23, 9:32 AM · Restricted Project, Restricted Project

Tue, Mar 21

labrinea planned changes to D145819: [FuncSpec] Increase the maximum number of times the specializer can run..
Tue, Mar 21, 7:49 AM · Restricted Project, Restricted Project
labrinea added a reviewer for D146158: [FuncSpec] Track the return values of specializations.: nikic.
Tue, Mar 21, 5:32 AM · Restricted Project, Restricted Project

Mon, Mar 20

labrinea added inline comments to D145379: [FuncSpec] Cost model improvements..
Mon, Mar 20, 8:03 AM · Restricted Project, Restricted Project

Fri, Mar 17

labrinea added inline comments to D146158: [FuncSpec] Track the return values of specializations..
Fri, Mar 17, 11:45 AM · Restricted Project, Restricted Project
labrinea updated the diff for D146158: [FuncSpec] Track the return values of specializations..
Fri, Mar 17, 11:44 AM · Restricted Project, Restricted Project
labrinea added inline comments to D145379: [FuncSpec] Cost model improvements..
Fri, Mar 17, 4:22 AM · Restricted Project, Restricted Project

Thu, Mar 16

labrinea planned changes to D146158: [FuncSpec] Track the return values of specializations..
Thu, Mar 16, 11:46 AM · Restricted Project, Restricted Project
labrinea added a comment to D146158: [FuncSpec] Track the return values of specializations..

Actually I have a WIP for recursively invalidating the lattice state of the users of such callsites and adding them back to the solver's worklist. Will run some tests and upload soon.

Thu, Mar 16, 11:46 AM · Restricted Project, Restricted Project
labrinea updated the diff for D145379: [FuncSpec] Cost model improvements..

Added a description of the cost model in the header file.

Thu, Mar 16, 9:14 AM · Restricted Project, Restricted Project
labrinea updated the diff for D145374: [FuncSpec] Consider constant struct arguments when specializing..

rebased on parent

Thu, Mar 16, 4:53 AM · Restricted Project, Restricted Project
labrinea added a comment to D145819: [FuncSpec] Increase the maximum number of times the specializer can run..

@SjoerdMeijer

As I said the compile time hit is attributed to the number of clones so these changes are coming from D145379 (added one extra specialization for sqlite3 and one for ClamAV when linking) and from D145394 (removed all the specializations for SPASS).

Thu, Mar 16, 3:02 AM · Restricted Project, Restricted Project

Wed, Mar 15

labrinea added a comment to D145819: [FuncSpec] Increase the maximum number of times the specializer can run..

@labrinea Is this patch the top-level patch for recursive function-specialization that benefits exchange2? Is there any setting required or would this perform specialization by default? Also, assuming this is with llvm-project/flang.

Wed, Mar 15, 12:03 PM · Restricted Project, Restricted Project
labrinea added inline comments to D145374: [FuncSpec] Consider constant struct arguments when specializing..
Wed, Mar 15, 11:18 AM · Restricted Project, Restricted Project
labrinea added a comment to D146158: [FuncSpec] Track the return values of specializations..

Alternatively I was thinking to remove the lattice value for the callsites whose called function has just been replaced. However I believe that might be incorrect, as the users of those callsites might be in a lattice state of less specificity (i.e. overdefined, or wider constant range).

Wed, Mar 15, 11:17 AM · Restricted Project, Restricted Project
labrinea requested review of D146158: [FuncSpec] Track the return values of specializations..
Wed, Mar 15, 11:08 AM · Restricted Project, Restricted Project
labrinea committed rG9627bcdeac33: [FuncSpec][NFC] Command line option renaming. (authored by labrinea).
[FuncSpec][NFC] Command line option renaming.
Wed, Mar 15, 11:04 AM · Restricted Project, Restricted Project
labrinea closed D145378: [FuncSpec][NFC] Command line option renaming..
Wed, Mar 15, 11:04 AM · Restricted Project, Restricted Project
labrinea committed rG67fde2b932a0: [FuncSpec] Minor refactoring in statistics and debug messages. (authored by labrinea).
[FuncSpec] Minor refactoring in statistics and debug messages.
Wed, Mar 15, 2:14 AM · Restricted Project, Restricted Project
labrinea closed D145375: [FuncSpec] Minor refactoring in statistics and debug messages..
Wed, Mar 15, 2:14 AM · Restricted Project, Restricted Project

Tue, Mar 14

labrinea committed rGf242291f59bf: [FuncSpec] Do not run pre-link when doing LTO. (authored by labrinea).
[FuncSpec] Do not run pre-link when doing LTO.
Tue, Mar 14, 11:57 AM · Restricted Project, Restricted Project
labrinea closed D145394: [FuncSpec] Do not run pre-link when doing LTO..
Tue, Mar 14, 11:57 AM · Restricted Project, Restricted Project

Mon, Mar 13

labrinea added inline comments to D145374: [FuncSpec] Consider constant struct arguments when specializing..
Mon, Mar 13, 10:04 AM · Restricted Project, Restricted Project

Sun, Mar 12

labrinea added a comment to D145819: [FuncSpec] Increase the maximum number of times the specializer can run..

Instruction Count delta
Comparison with base (parent of D145374 - top of the chain)

Sun, Mar 12, 9:27 AM · Restricted Project, Restricted Project
labrinea added a comment to D145819: [FuncSpec] Increase the maximum number of times the specializer can run..

Bumps the score of 548.exchange2_r from SPEC2017 by about 60% on Neoverse N1.

Can we achieve this with lower FuncSpecMaxIters than 10 as 10 could be quite constly in terms of compile times?

Sun, Mar 12, 8:43 AM · Restricted Project, Restricted Project

Sat, Mar 11

labrinea added a comment to D145819: [FuncSpec] Increase the maximum number of times the specializer can run..

Bumps the score of 548.exchange2_r from SPEC2017 by about 60% on Neoverse N1.

Sat, Mar 11, 3:02 AM · Restricted Project, Restricted Project

Fri, Mar 10

labrinea requested review of D145819: [FuncSpec] Increase the maximum number of times the specializer can run..
Fri, Mar 10, 11:38 AM · Restricted Project, Restricted Project
labrinea updated the diff for D145379: [FuncSpec] Cost model improvements..

Adjusted the test output for recursive-penalty.ll. Decreasing MinScore from 100 to 80 translates to 10 instead of 8 specializations being created for the test.

Fri, Mar 10, 11:38 AM · Restricted Project, Restricted Project
labrinea updated the diff for D145379: [FuncSpec] Cost model improvements..

Changes from last revision:

  • Removed redefinition of SpecMap type from the header file.
  • Removed @param Cost from the description of findSpecializations() in the header file.
  • Decreased the value of MinScore from 100 to 80 as it no longer specialized mcf_r from SPEC2017.
Fri, Mar 10, 11:16 AM · Restricted Project, Restricted Project

Tue, Mar 7

labrinea added inline comments to D145379: [FuncSpec] Cost model improvements..
Tue, Mar 7, 2:33 AM · Restricted Project, Restricted Project

Mon, Mar 6

labrinea added a comment to D145394: [FuncSpec] Do not run pre-link when doing LTO..

Improves geomean of CTMark by a tiny bit (-0.06 % instruction count).

Mon, Mar 6, 8:54 AM · Restricted Project, Restricted Project
labrinea requested review of D145394: [FuncSpec] Do not run pre-link when doing LTO..
Mon, Mar 6, 8:50 AM · Restricted Project, Restricted Project
labrinea added a comment to D145379: [FuncSpec] Cost model improvements..

Old cost model (LTO)

Mon, Mar 6, 6:41 AM · Restricted Project, Restricted Project
labrinea requested review of D145379: [FuncSpec] Cost model improvements..
Mon, Mar 6, 6:29 AM · Restricted Project, Restricted Project
labrinea requested review of D145378: [FuncSpec][NFC] Command line option renaming..
Mon, Mar 6, 6:26 AM · Restricted Project, Restricted Project
labrinea requested review of D145375: [FuncSpec] Minor refactoring in statistics and debug messages..
Mon, Mar 6, 6:24 AM · Restricted Project, Restricted Project
labrinea requested review of D145374: [FuncSpec] Consider constant struct arguments when specializing..
Mon, Mar 6, 6:21 AM · Restricted Project, Restricted Project

Jan 24 2023

labrinea closed D140210: [IPSCCP] Enable specialization of functions..

The above issue has been fixed.

Jan 24 2023, 4:21 PM · Restricted Project, Restricted Project
labrinea committed rG33ecc8a9b8b0: [IPSCCP][FuncSpec] Fix compiler crash 60191. (authored by labrinea).
[IPSCCP][FuncSpec] Fix compiler crash 60191.
Jan 24 2023, 10:41 AM · Restricted Project, Restricted Project
labrinea closed D142444: [IPSCCP][FuncSpec] Fix compiler crash 60191..
Jan 24 2023, 10:40 AM · Restricted Project, Restricted Project
labrinea updated the diff for D142444: [IPSCCP][FuncSpec] Fix compiler crash 60191..

Added the missing filecheck command to the run line of the test.

Jan 24 2023, 7:54 AM · Restricted Project, Restricted Project
labrinea added inline comments to D142444: [IPSCCP][FuncSpec] Fix compiler crash 60191..
Jan 24 2023, 7:48 AM · Restricted Project, Restricted Project
labrinea updated the diff for D142444: [IPSCCP][FuncSpec] Fix compiler crash 60191..

Changes from last revision:

  • early exit the calculation of specialization bonus when the function type mismatches instead of just the number of arguments
  • reduced the test case further, removed the target triple, and specified the ipsccp pass only instead of O3
Jan 24 2023, 7:37 AM · Restricted Project, Restricted Project
labrinea added inline comments to D142444: [IPSCCP][FuncSpec] Fix compiler crash 60191..
Jan 24 2023, 6:26 AM · Restricted Project, Restricted Project
labrinea added inline comments to D142444: [IPSCCP][FuncSpec] Fix compiler crash 60191..
Jan 24 2023, 2:38 AM · Restricted Project, Restricted Project
labrinea requested review of D142444: [IPSCCP][FuncSpec] Fix compiler crash 60191..
Jan 24 2023, 2:24 AM · Restricted Project, Restricted Project

Jan 13 2023

labrinea committed rG572a757fa787: [IPSCCP] Enable specialization of functions. (authored by labrinea).
[IPSCCP] Enable specialization of functions.
Jan 13 2023, 6:05 AM · Restricted Project, Restricted Project
labrinea closed D140210: [IPSCCP] Enable specialization of functions..
Jan 13 2023, 6:04 AM · Restricted Project, Restricted Project

Jan 12 2023

labrinea closed D141474: [SPEC2017] Use -fno-strict-aliasing when compiling 502.gcc_r, 505.mcf_r.
Jan 12 2023, 9:01 AM · Restricted Project
labrinea committed rT0bf641816abe: [SPEC2017] Use -fno-strict-aliasing when compiling 502.gcc_r, 505.mcf_r (authored by labrinea).
[SPEC2017] Use -fno-strict-aliasing when compiling 502.gcc_r, 505.mcf_r
Jan 12 2023, 9:01 AM · Restricted Project
labrinea updated the diff for D141474: [SPEC2017] Use -fno-strict-aliasing when compiling 502.gcc_r, 505.mcf_r.

Added the flag to 505.mcf_r as well.

Jan 12 2023, 3:15 AM · Restricted Project
labrinea added a comment to D141474: [SPEC2017] Use -fno-strict-aliasing when compiling 502.gcc_r, 505.mcf_r.

Is this change perf-neutral?

Jan 12 2023, 3:11 AM · Restricted Project
labrinea updated the diff for D140210: [IPSCCP] Enable specialization of functions..

I've added a release note about D141474.

Jan 12 2023, 2:33 AM · Restricted Project, Restricted Project
labrinea reopened D140210: [IPSCCP] Enable specialization of functions..
Jan 12 2023, 2:32 AM · Restricted Project, Restricted Project

Jan 11 2023

labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

For people who compile SPEC outside llvm test suite, there should be a note in release notes about this issue..

Jan 11 2023, 6:23 AM · Restricted Project, Restricted Project
labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

Good find. I am happy with that explanation, and I think we could try again. Does it mean that this flags needs to be added to the llvm test-suite?

Yes, I've created D141474

In terms of reenabling this, Dave pointed out to me that the next release is not that far away, so the question is if we want to recommit now or shortly after the release?

I would like to re-enable it before the release. There haven't been other regressions reported so far, plus we've built Clang and Chromium successfully, which is quite reassuring.

Jan 11 2023, 3:19 AM · Restricted Project, Restricted Project
labrinea added a comment to D141474: [SPEC2017] Use -fno-strict-aliasing when compiling 502.gcc_r, 505.mcf_r.

Hmm, I am wondering whether I should add the flag to 505.mcf_r too, despite it's not failing.

Jan 11 2023, 2:35 AM · Restricted Project
labrinea requested review of D141474: [SPEC2017] Use -fno-strict-aliasing when compiling 502.gcc_r, 505.mcf_r.
Jan 11 2023, 2:20 AM · Restricted Project

Jan 10 2023

labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

Oh wait, -fno-strict-aliasing is not being used in the first place! That explains the failure:

Known Portability Issues

  1. spec_qsort and ANSI aliasing: The spec_qsort.c routine does not strictly obey the ANSI aliasing rules. See the detailed discussion in the documentation for 505.mcf_r, which is where the problem was reported. If you are compiling with the GCC compiler, it is theoretically possible that you might need to add -fno-strict-aliasing to 502.gcc_r as well. The Example GCC config files as updated for SPEC CPU 2017 v1.1.5 demonstrate how to do so.
Jan 10 2023, 12:48 PM · Restricted Project, Restricted Project
labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

After some experimentation I found that the specialization of spec_qsort with case_bit_test_cmp as the compare function causes the problem. Digging a little more in the SPEC documentation I found these portability issues which seem to manifest when FuncSpec is enabled:

Jan 10 2023, 7:13 AM · Restricted Project, Restricted Project

Jan 5 2023

labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

It looks like CINT2017rate/502.gcc_r gets mis-compiled with LTO + PGO on
AArch64 with function specialization. I reverted the patch for now.

Thanks for looking after this. Can you share more details about your environment, or perhaps a reproducer? I haven't been able to reproduce the mis-compilation of CINT2017rate/502.gcc_r myself on AArch64 with LTO + PGO.

Jan 5 2023, 5:07 AM · Restricted Project, Restricted Project

Jan 3 2023

labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

It looks like CINT2017rate/502.gcc_r gets mis-compiled with LTO + PGO on
AArch64 with function specialization. I reverted the patch for now.

Jan 3 2023, 9:16 AM · Restricted Project, Restricted Project

Dec 25 2022

labrinea committed rG2656572d4851: [IPSCCP] Enable specialization of functions. (authored by labrinea).
[IPSCCP] Enable specialization of functions.
Dec 25 2022, 4:30 AM · Restricted Project, Restricted Project
labrinea closed D140210: [IPSCCP] Enable specialization of functions..
Dec 25 2022, 4:30 AM · Restricted Project, Restricted Project

Dec 23 2022

labrinea committed rGf952bc05fda6: [IPSCCP] Create a Pass parameter to control specialization of functions. (authored by labrinea).
[IPSCCP] Create a Pass parameter to control specialization of functions.
Dec 23 2022, 9:07 AM · Restricted Project, Restricted Project
labrinea closed D140564: [IPSCCP] Create a Pass parameter to control specialization of functions..
Dec 23 2022, 9:06 AM · Restricted Project, Restricted Project
labrinea updated the diff for D140210: [IPSCCP] Enable specialization of functions..

rebase

Dec 23 2022, 8:38 AM · Restricted Project, Restricted Project
labrinea added inline comments to D140564: [IPSCCP] Create a Pass parameter to control specialization of functions..
Dec 23 2022, 4:45 AM · Restricted Project, Restricted Project
labrinea updated the diff for D140564: [IPSCCP] Create a Pass parameter to control specialization of functions..
  • Removed the cmdline option -specialize-functions.
  • Changed the IPSCCPOption 'AllowFuncSpec' from std::optional<bool> to bool.
Dec 23 2022, 4:44 AM · Restricted Project, Restricted Project
labrinea added inline comments to D140564: [IPSCCP] Create a Pass parameter to control specialization of functions..
Dec 23 2022, 4:13 AM · Restricted Project, Restricted Project
labrinea added inline comments to D140564: [IPSCCP] Create a Pass parameter to control specialization of functions..
Dec 23 2022, 4:05 AM · Restricted Project, Restricted Project

Dec 22 2022

labrinea updated the diff for D140210: [IPSCCP] Enable specialization of functions..
  • Rebased on D140564.
  • Added release notes.
Dec 22 2022, 11:47 AM · Restricted Project, Restricted Project
labrinea requested review of D140564: [IPSCCP] Create a Pass parameter to control specialization of functions..
Dec 22 2022, 9:43 AM · Restricted Project, Restricted Project
labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

So I had a last minute thought as I was updating the Release Notes. Currently IPSCCP runs on all optimization levels. Consequently FuncSpec does too. Should we disable the latter for Os, Oz and perhaps O1?

Dec 22 2022, 4:04 AM · Restricted Project, Restricted Project
labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

Many thanks to everyone who contributed in making this happen! I am so stoked! Regarding the release notes, shall I add a section named "Changes to Interprocedural Optimizations" and say something along the lines of "Function Specialization has been integrated in IPSCCP and it is now enabled by default"?

Dec 22 2022, 2:40 AM · Restricted Project, Restricted Project

Dec 21 2022

labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

I've measured user + system time (average of five runs) and the results are inconclusive: baseline 42663.2s vs patch 42657.1s (delta -0.014%). The experiment was to build LLVM using the patched compiler/linker with LTO as requested. It doesn't seem like a useful metric to me, but now I've checked it off my list :)

I am not sure I understand, how can building llvm (with your patched compiler) and measure compile times (in time and/or in instruction counts) not be a useful exercise in this context?

Dec 21 2022, 7:55 AM · Restricted Project, Restricted Project
labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

Great stuff, and impressive numbers, I think they look really good.

CTMark compile time numbers look really good. I was thinking if we could at least add one more data point: timed compilation of LLVM. I would be interested in both the instruction count increase, like you reported for CTMark, but also in absolute timings just to get an idea. And you built Chromium for correctness testing (nice!), did you get any compile time numbers while doing that exercise?

I have measured the time spent on the IPSCCP pass itself (user+system time) during linking using the -time-passes option on lld. On my x86 machine with O3 and Full LTO the Geomean of CTMark goes from ~152ms to ~174ms resulting +14.47% increase (average of five best runs). Regarding the Chromium build, no I haven't measured compilation times.

When I looked into this, I found that the increase in compile-times wasn't caused by the function specialization pass itself, the time spent in there was negligible, but the extra went into the the subsequent passes having to work more and harder. So I don't think measuring the time spent in IPSCCP is the right metric we want to be using, although I agree of course it is interesting to see if there's not something very expensive going on. The instruction count that you used for CTMark is a much better metric. In my first comment I was curious how that would look like for one more data point, timed LLVM compilation, and also how that translate to time just out of curiousity.

Dec 21 2022, 6:53 AM · Restricted Project, Restricted Project

Dec 20 2022

labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

So I had a closer look to the code size increase in terminator.c from SPASS. This is the breakdown of LOC for the x86 disassembly:

Dec 20 2022, 8:07 AM · Restricted Project, Restricted Project
labrinea added inline comments to D140210: [IPSCCP] Enable specialization of functions..
Dec 20 2022, 7:23 AM · Restricted Project, Restricted Project
labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

I looked at the source code of terminator.c. It contains five function definitions and includes a bunch of inlined functions from the header files, that's why llvm::Module::size() reports hundreds. From five to six functions is roughly a ~20ish % codesize increase for the intermediate object file. The final object shouldn't be as much affected, so it doesn't seem worrying to me.

Dec 20 2022, 4:22 AM · Restricted Project, Restricted Project

Dec 19 2022

labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

@nikic can you share the configuration where you see the 50% increase of codesize in terminator.c (which optimization pipeline)? Since it is an intermediate object file I presume the specialization happens during the compilation phase, not when linking. When I build CTMark with Full LTO and debug output I am seeing:

Dec 19 2022, 7:28 AM · Restricted Project, Restricted Project
labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

Great stuff, and impressive numbers, I think they look really good.

CTMark compile time numbers look really good. I was thinking if we could at least add one more data point: timed compilation of LLVM. I would be interested in both the instruction count increase, like you reported for CTMark, but also in absolute timings just to get an idea. And you built Chromium for correctness testing (nice!), did you get any compile time numbers while doing that exercise?

Dec 19 2022, 6:49 AM · Restricted Project, Restricted Project

Dec 16 2022

labrinea added a comment to D140210: [IPSCCP] Enable specialization of functions..

Some more detailed compile-time data: https://llvm-compile-time-tracker.com/compare.php?from=e6676a1382ff4c8f6c520486323430745948481d&to=8d528eb8ebe0261d187fef57829f1db20f42752c&stat=instructions%3Au

I notice that there is a 50% increase in code size on terminator.c from SPASS. Did this large change get analyzed at some point?

Dec 16 2022, 9:42 AM · Restricted Project, Restricted Project
labrinea requested review of D140210: [IPSCCP] Enable specialization of functions..
Dec 16 2022, 5:22 AM · Restricted Project, Restricted Project

Dec 14 2022

labrinea accepted D139346: [FuncSpec] Global ranking of specialisations.
Dec 14 2022, 4:21 AM · Restricted Project, Restricted Project

Dec 12 2022

labrinea abandoned D135463: [FuncSpec] Do not generate multiple copies for identical specializations..

This patch achieves the same as D139346 with ~0.001% (geomean) increase of Instruction Count for CTMark (LTO) or ~0.033% (geomean) increase of execution time (user+system) for the IPSCCP pass. I am abandoning this patch in favor of D139346.

Dec 12 2022, 8:40 AM · Restricted Project, Restricted Project

Dec 11 2022

labrinea added inline comments to D139346: [FuncSpec] Global ranking of specialisations.
Dec 11 2022, 7:23 AM · Restricted Project, Restricted Project
labrinea accepted D139346: [FuncSpec] Global ranking of specialisations.

Compilation times look way better now, thanks!

Dec 11 2022, 7:02 AM · Restricted Project, Restricted Project

Dec 10 2022

labrinea committed rG8136a0172b3c: [FuncSpec] Make the Function Specializer part of the IPSCCP pass. (authored by labrinea).
[FuncSpec] Make the Function Specializer part of the IPSCCP pass.
Dec 10 2022, 6:50 AM · Restricted Project, Restricted Project

Dec 9 2022

labrinea added inline comments to D138654: [IPSCCP] Move the IPSCCP run function under the IPO directory..
Dec 9 2022, 8:44 AM · Restricted Project, Restricted Project
labrinea committed rG9ebaf4fef4aa: [IPSCCP] Move the IPSCCP run function under the IPO directory. (authored by labrinea).
[IPSCCP] Move the IPSCCP run function under the IPO directory.
Dec 9 2022, 7:06 AM · Restricted Project, Restricted Project
labrinea closed D138654: [IPSCCP] Move the IPSCCP run function under the IPO directory..
Dec 9 2022, 7:05 AM · Restricted Project, Restricted Project
labrinea requested review of D138654: [IPSCCP] Move the IPSCCP run function under the IPO directory..
Dec 9 2022, 6:21 AM · Restricted Project, Restricted Project
labrinea reopened D138654: [IPSCCP] Move the IPSCCP run function under the IPO directory..
Dec 9 2022, 6:21 AM · Restricted Project, Restricted Project
labrinea updated the diff for D138654: [IPSCCP] Move the IPSCCP run function under the IPO directory..

The previous commit regressed some buildbots:

Dec 9 2022, 6:21 AM · Restricted Project, Restricted Project

Dec 8 2022

labrinea added a reverting change for rG42c2dc401742: [IPSCCP] Move the IPSCCP run function under the IPO directory.: rGcb03b1bd9931: Revert "[IPSCCP] Move the IPSCCP run function under the IPO directory.".
Dec 8 2022, 4:45 AM · Restricted Project, Restricted Project
labrinea committed rGcb03b1bd9931: Revert "[IPSCCP] Move the IPSCCP run function under the IPO directory." (authored by labrinea).
Revert "[IPSCCP] Move the IPSCCP run function under the IPO directory."
Dec 8 2022, 4:45 AM · Restricted Project, Restricted Project