This is an archive of the discontinued LLVM Phabricator instance.

[lld][WebAssembly] Limit size of shared 64-bit memories of 2^^34
ClosedPublic

Authored by sbc100 on Feb 10 2023, 3:00 PM.

Details

Summary

This is current limit in v8. See
https://github.com/WebAssembly/memory64/issues/33 how we might change
this in the future.

Diff Detail

Event Timeline

sbc100 created this revision.Feb 10 2023, 3:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2023, 3:00 PM
Herald added subscribers: pmatos, asb, wingo and 4 others. · View Herald Transcript
sbc100 requested review of this revision.Feb 10 2023, 3:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2023, 3:00 PM

Working on adding a test now. This is needed to run wasm64 + pthread + dynamic linking tests on the emscripten side.

dschuff accepted this revision.Feb 10 2023, 3:36 PM

LGTM with a test.

This revision is now accepted and ready to land.Feb 10 2023, 3:36 PM
This revision was landed with ongoing or failed builds.Feb 13 2023, 12:22 PM
This revision was automatically updated to reflect the committed changes.