This is an archive of the discontinued LLVM Phabricator instance.

[flang] Remove macro replacement in angular bracket includes
ClosedPublic

Authored by elmcdonough on Feb 6 2023, 11:54 PM.

Diff Detail

Event Timeline

elmcdonough created this revision.Feb 6 2023, 11:54 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: jdoerfert. · View Herald Transcript
elmcdonough requested review of this revision.Feb 6 2023, 11:54 PM
clementval added inline comments.
flang/lib/Parser/preprocessor.cpp
602

clang-fromat issue here.

flang/test/Preprocessing/preserve-brace-include.F90
5

You should check the output with FileCheck.

klausler added inline comments.Feb 7 2023, 8:15 AM
flang/lib/Parser/preprocessor.cpp
602

Don't retain the old bad line in a comment.

I fixed the formatting and test.

pscoro added a subscriber: pscoro.Feb 8 2023, 2:22 PM

Please coordinate with https://reviews.llvm.org/D143606

Closed mine, was identical minus test case. There was no assignee on the github issue

elmcdonough retitled this revision from Remove macro replacement in angular bracket includes to [flang] Remove macro replacement in angular bracket includes.Feb 16 2023, 2:50 PM
klausler accepted this revision.Feb 16 2023, 2:59 PM
This revision is now accepted and ready to land.Feb 16 2023, 2:59 PM