This is an archive of the discontinued LLVM Phabricator instance.

[clang][deps] Fix race condition
ClosedPublic

Authored by jansvoboda11 on Feb 6 2023, 11:41 AM.

Details

Summary

D140176 introduced new FullDeps API that's not thread-safe, breaking the class invariant. This was causing race condition when clang-scan-deps was run with multiple threads.

Diff Detail

Event Timeline

jansvoboda11 created this revision.Feb 6 2023, 11:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2023, 11:41 AM
Herald added a subscriber: ributzka. · View Herald Transcript
jansvoboda11 requested review of this revision.Feb 6 2023, 11:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2023, 11:41 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
akyrtzi accepted this revision.Feb 7 2023, 8:39 AM
This revision is now accepted and ready to land.Feb 7 2023, 8:39 AM
steven_wu accepted this revision.Feb 7 2023, 9:20 AM
This revision was automatically updated to reflect the committed changes.