This is an archive of the discontinued LLVM Phabricator instance.

[libc++][ranges] move all range iterators back in class
ClosedPublic

Authored by huixie90 on Feb 4 2023, 10:09 AM.

Details

Summary

move all range iterators back in class, as out of class iterators
requires extra template parameters, which changes ADL

Diff Detail

Event Timeline

huixie90 created this revision.Feb 4 2023, 10:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2023, 10:09 AM
huixie90 requested review of this revision.Feb 4 2023, 10:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2023, 10:09 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
huixie90 updated this revision to Diff 494904.Feb 5 2023, 5:56 AM

add tests

ldionne accepted this revision.Feb 8 2023, 1:34 PM

Thanks for fixing this! Let's cherry-pick this as well.

This revision is now accepted and ready to land.Feb 8 2023, 1:34 PM
This revision was landed with ongoing or failed builds.Feb 11 2023, 7:42 AM
This revision was automatically updated to reflect the committed changes.