AVX512: Implemented encoding and intrinsics for VMOVSHDUP/VMOVSLDUP instructions.
Added tests for intrinsics and encoding.
Details
- Reviewers
AsafBadouh delena - Commits
- rG24cab0fa060c: AVX512: Implemented encoding and intrinsics for VMOVSHDUP/VMOVSLDUP…
rGaa40ddd3ba7b: AVX512: Implemented encoding and intrinsics for VMOVSHDUP/VMOVSLDUP…
rL253185: AVX512: Implemented encoding and intrinsics for VMOVSHDUP/VMOVSLDUP…
rL253160: AVX512: Implemented encoding and intrinsics for VMOVSHDUP/VMOVSLDUP…
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/Target/X86/InstPrinter/X86InstComments.cpp | ||
---|---|---|
175 | I propose to add some helper functions, like isZMMReg(), isYMMReg(), isXMMReg(), | |
211 | We can examine the number of operands in order see if the instruction has memory operand. | |
245 | remove empty line |
lib/Target/X86/InstPrinter/X86InstComments.cpp | ||
---|---|---|
346–347 | Wouldn't it be better to match the 'fall through' pattern that we have for most rm / rr shuffle pairs instead of using operand count to re-determine if its rm? It would mean a splitting of the CASE_MOVDUP into 2 versions though. |
lib/Target/X86/InstPrinter/X86InstComments.cpp | ||
---|---|---|
193 | We already have CASE_VSHUF_COMMON / CASE_VSHUF - is there any way that we can start standardizing these macros so that they can be reused as much as possible please? |
It broke layering violation. Reproducible with BUILD_SHARED_LIBS=ON.
X86AsmPrinter might require X86Desc but X86Desc requires X86AsmPrinter.
Operand index should be explicit.
The second parameter: MVT ScalarVT