User Details
User Details
- User Since
- Nov 4 2014, 1:36 AM (254 w, 2 d)
Jan 24 2017
Jan 24 2017
AsafBadouh updated the diff for D28354: [X86][MCU] replace select with bit manipulation instead of branches.
Great catch Igor,
the transformation is not valid to select (and (x & 0x1) == 0) , (z ^ y), y ),
for that we will need an extra instruction to create the mask.
I change the algorithm to catch only: select (and (x & 0x1) == 0) , y, (z ^ y) )
Jan 15 2017
Jan 15 2017
AsafBadouh updated the diff for D28354: [X86][MCU] replace select with bit manipulation instead of branches.
changes according to Igor review.
Jan 12 2017
Jan 12 2017
AsafBadouh added a comment to D28503: Documentation for the newly added x86 intrinsics..
LGTM
Jan 5 2017
Jan 5 2017
AsafBadouh retitled D28354: [X86][MCU] replace select with bit manipulation instead of branches from to [X86][MCU] replace select with bit manipulation instead of branches.
Nov 27 2016
Nov 27 2016
Nov 20 2016
Nov 20 2016
AsafBadouh retitled D26895: [X86][LMT] Restrict nop length to one from to [X86][LMT] Restrict nop length to one.
Nov 10 2016
Nov 10 2016
AsafBadouh updated the diff for D26449: DAGCombiner: fix combine of trunc and select.
- update the regression tests.
- used the utils/update_llc_test_checks.py to auto-generate complete checks.
AsafBadouh updated the diff for D26449: DAGCombiner: fix combine of trunc and select.
+ Sanjay
fixes pr29002
update the test case using the example in pr29002
Nov 9 2016
Nov 9 2016
AsafBadouh updated the diff for D26449: DAGCombiner: fix combine of trunc and select.
AsafBadouh retitled D26449: DAGCombiner: fix combine of trunc and select from to DAGCombiner: fix combine of trunc and select.
Sep 11 2016
Sep 11 2016
LGTM
Aug 21 2016
Aug 21 2016
AsafBadouh retitled D23753: [AVX512] Arguments to _mm512_[mask_]abs_ps|d must have "__" prefix from to [AVX512] Arguments to _mm512_[mask_]abs_ps|d must have "__" prefix .
Aug 14 2016
Aug 14 2016
LGTM
Aug 3 2016
Aug 3 2016
AsafBadouh updated subscribers of D23108: Implemented 132/213/231 forms selection for X86-FMA3-AVX512 opcodes..
Jul 11 2016
Jul 11 2016
AsafBadouh retitled D22212: [X86][AVX512] Constants for integer comparison predicates from to [X86][AVX512] Constants for integer comparison predicates .
Jul 5 2016
Jul 5 2016
AsafBadouh added inline comments to D21973: [AVX512] add float/double abs intrinsics.
AsafBadouh retitled D21988: [AVX512] minor fix in sqrt{ss|sd} intrinsics arguments from to [AVX512] minor fix in sqrt{ss|sd} intrinsics arguments.
Jul 4 2016
Jul 4 2016
AsafBadouh retitled D21973: [AVX512] add float/double abs intrinsics from to [AVX512] add float/double abs intrinsics.
Jun 26 2016
Jun 26 2016
AsafBadouh updated the diff for D21504: [X86] add _mm_loadu_si64.
Jun 23 2016
Jun 23 2016
AsafBadouh updated the diff for D21504: [X86] add _mm_loadu_si64.
add align to CHECK
Jun 19 2016
Jun 19 2016
AsafBadouh updated the diff for D21504: [X86] add _mm_loadu_si64.
small changes according to Simon review.
Jun 5 2016
Jun 5 2016
Jun 1 2016
Jun 1 2016
AsafBadouh added inline comments to D20866: [Clang][AVX512]Adding set4 intrinsics .
minor fixes, LGTM
AsafBadouh retitled D20861: [AVX512] add missing integer to float conversion from to [AVX512] add missing integer to float conversion.
May 25 2016
May 25 2016
LGTM with small fix
LGTM
AsafBadouh accepted D19914: Adding front-end support to several intrinsics (bit scanning, conversion and state reading intrinsics).
LGTM
LGTM
May 23 2016
May 23 2016
AsafBadouh accepted D20521: [Clang][AVX512][Builtin] adding missing intrinsics for vpmultishiftqb{128|256|512} instruction set .
LGTM
AsafBadouh updated the diff for D20518: [X86][RTM] _xabort() should not have "noreturn" attribute.
test added
AsafBadouh added a reviewer for D20518: [X86][RTM] _xabort() should not have "noreturn" attribute: hliao.
AsafBadouh retitled D20518: [X86][RTM] _xabort() should not have "noreturn" attribute from to [X86][RTM] _xabort() should not have "noreturn" attribute.
May 19 2016
May 19 2016
LGTM
AsafBadouh accepted D20160: [Clang][AVX512][intrinsics] continue completing missing set intrinsics .
LGTM
May 18 2016
May 18 2016
LGTM
AsafBadouh added inline comments to D20101: [Clang][AVX512] completing missing intrinsics [pandnd]..
May 10 2016
May 10 2016
AsafBadouh accepted D20096: [Clang][AVX512] completing missing intrinsics for [vpermt2d|vptestm] instruction set..
LGTM
LGTM
AsafBadouh added inline comments to D20096: [Clang][AVX512] completing missing intrinsics for [vpermt2d|vptestm] instruction set..
AsafBadouh added inline comments to D20063: [Clang][AVX512] completing missing intrinsics [load/store]..
AsafBadouh accepted D20064: [Clang][AVX512] completing missing intrinsics [vmin/vmax]{sd|sq|uq|ud}..
LGTM
LGTM
May 9 2016
May 9 2016
LGTM
May 8 2016
May 8 2016
AsafBadouh added inline comments to D20055: [Clang][Intrinsics] Adding avx512f missing intrinsics {cast} .
May 4 2016
May 4 2016
AsafBadouh added inline comments to D19915: Adding back-end support to two bit scanning intrinsics.
May 3 2016
May 3 2016
AsafBadouh accepted D19765: [Clang][Builtin][AVX512] Adding intrinsics fot cvt{u}si2s{d|s} cvt{sd|ss}2{ss|sd} instruction set .
LGTM
AsafBadouh accepted D19858: [Clang][AVX512][BuiltIn] Adding intrinsics for cast{pd|ps|si}128_{pd|ps|si}512 and castsi256_si512 instruction set..
LTGM
AsafBadouh accepted D19766: [Clang][avx512][Builtin] Adding intrinsics for cvtw2mask{128|256|512} instruction set.
LGTM
May 2 2016
May 2 2016
May 1 2016
May 1 2016
AsafBadouh accepted D19467: [Clang][avx512][builtin] Adding intrinsics for vexpand{d|q|ps|pd} instrctuon set .
LGTM
AsafBadouh accepted D19580: [Clang][BuiltIn][avx512] Adding intrinsics for vpshufd instruction set .
lgtm
AsafBadouh accepted D19595: [Clang][Builtin][AVX512] Adding intrinsics for vmovshdup and vmovsldup instruction set.
LGTM
Apr 27 2016
Apr 27 2016
AsafBadouh added a comment to D19467: [Clang][avx512][builtin] Adding intrinsics for vexpand{d|q|ps|pd} instrctuon set .
intrinsics with zero masks (maskz) are missing.
AsafBadouh accepted D19588: [Clang][BuiltIn][AVX512] Adding intrinsics fot align{d|q} and palignr instruction set.
please change from setzero to undefined in the non mask versions.
LGTM after that.
Apr 26 2016
Apr 26 2016
AsafBadouh accepted D19529: [Clang][BuiltIn][AVX512]Adding intrinsics for vmovntdqa vmovntpd vmovntps instruction set.
minor fixes, LGTM
AsafBadouh accepted D19525: [Clang][Builtin][AVX512] Adding intrisnics for the vpconflict{q|d} instruction set.
I just saw the dependency review, LGTM after it done.
AsafBadouh added a comment to D19525: [Clang][Builtin][AVX512] Adding intrisnics for the vpconflict{q|d} instruction set.
you need to add avx512vlcdintrin.h to:
- /lib/Headers/CMakeLists.txt
- /lib/Headers/immintrin.h
Apr 25 2016
Apr 25 2016
AsafBadouh accepted D19466: [Clang][Builtin][AVX512]Adding k-register logic intrinsics KAND, KANDN, KOR, KORTEST, KXNOR, KXOR, KUNPACK instruction set. .
LGTM
AsafBadouh accepted D19476: [Clang][Builtin][AVX512]Adding intrinsics for vfpclass{sd|ss} vfpclass{pd|ps} instruction set.
minor fixes, LGTM
AsafBadouh added a comment to D19476: [Clang][Builtin][AVX512]Adding intrinsics for vfpclass{sd|ss} vfpclass{pd|ps} instruction set.
tests are missing
Apr 24 2016
Apr 24 2016
AsafBadouh accepted D19195: [Clang][AVX512][BuiltIn] Adding support to intrinsics of VPERMD and VPERMW instruction set .
LGTM
Apr 21 2016
Apr 21 2016
AsafBadouh added inline comments to D19040: Remove unnecessary load via GOT when accessing globals with PIE in x86_64.
Apr 19 2016
Apr 19 2016
AsafBadouh updated the diff for D19226: [X86] enable PIE for functions.
update according to Reid comments.
AsafBadouh added inline comments to D19226: [X86] enable PIE for functions.
AsafBadouh updated the diff for D19226: [X86] enable PIE for functions.
run clang-format and add other linkage testcases
AsafBadouh added inline comments to D19226: [X86] enable PIE for functions.
Apr 18 2016
Apr 18 2016
AsafBadouh added inline comments to D19195: [Clang][AVX512][BuiltIn] Adding support to intrinsics of VPERMD and VPERMW instruction set .
Apr 17 2016
Apr 17 2016
AsafBadouh accepted D19197: [Clang][Builtin][AVX512] Adding intrinsics for VGETMANT{PD|PS} and VGETEXP{PD|PS} instruction set.
LGTM
AsafBadouh added inline comments to D19195: [Clang][AVX512][BuiltIn] Adding support to intrinsics of VPERMD and VPERMW instruction set .
AsafBadouh added inline comments to D19040: Remove unnecessary load via GOT when accessing globals with PIE in x86_64.
Apr 13 2016
Apr 13 2016
AsafBadouh added a comment to D18942: [X86] remove unneeded variables.
Hey Rafael,
can you please review this minor change?
Thanks,
Asaf
Apr 12 2016
Apr 12 2016
AsafBadouh accepted D19009: [Clang][Builtin][AVX512] Adding builtin to clang . [cvt{b|d|q}2mask{128|256|512} cvtmask2{b|d|q}{128|256|512}] .
LGTM
AsafBadouh added inline comments to D18861: [CLANG][AVX512][BUILTIN] Completing and Adding scalar Intrinsics to clang .
Apr 11 2016
Apr 11 2016
AsafBadouh accepted D18926: [Clang][AVX512][BuiltIn] Adding avx512 ( psll{d|q}512,psllv{16si|8di},psra{d|q}512,psrav{16si|8di},pternlog{d|q}{128|256|512} ) builtin to clang ....
LGTM
LGTM
AsafBadouh added a comment to D18926: [Clang][AVX512][BuiltIn] Adding avx512 ( psll{d|q}512,psllv{16si|8di},psra{d|q}512,psrav{16si|8di},pternlog{d|q}{128|256|512} ) builtin to clang ....
there are some tests duplication
AsafBadouh updated subscribers of D18942: [X86] remove unneeded variables.
Apr 10 2016
Apr 10 2016
AsafBadouh added inline comments to D18930: Adding avx512 (shuf,sqrt{ss|sd},rsqrt ) builtin to clang .
AsafBadouh retitled D18942: [X86] remove unneeded variables from to [X86] remove unneeded variables.
AsafBadouh accepted D18924: [Clang][AVX512][BuiltIn] Adding avx512 ( ptest{n}m{b|w}{128|256|512} ) builtin to clang ...
see comments
LGTM
AsafBadouh added a comment to D18926: [Clang][AVX512][BuiltIn] Adding avx512 ( psll{d|q}512,psllv{16si|8di},psra{d|q}512,psrav{16si|8di},pternlog{d|q}{128|256|512} ) builtin to clang ....
there are duplication in the headers and in the tests.
Apr 3 2016
Apr 3 2016
AsafBadouh added inline comments to D18446: [Clang][avx512][Builtin] Adding Builtin to clang. .
Mar 28 2016
Mar 28 2016
AsafBadouh accepted D18215: [CLANG][avx512][BUILTIN] Adding fixupimm{pd|ps|sd|ss} getexp{sd|ss} getmant{sd|ss} kunpck{di|si} loada{pd|ps} loaddqu{di|hi|qi|si} max{sd|ss} min{sd|ss} kmov16 builtins to clang.
LGTM
Mar 17 2016
Mar 17 2016
Mar 16 2016
Mar 16 2016
Feb 24 2016
Feb 24 2016
LGTM
Feb 22 2016
Feb 22 2016
Feb 18 2016
Feb 18 2016
AsafBadouh accepted D16961: [CLANG] [AVX512] [BUILTIN] Adding pmovzx{b|d|w}{w|d|q}{128|256|512} builtin to clang .
LGTM
Feb 17 2016
Feb 17 2016
AsafBadouh added inline comments to D17289: [X86] Fix False Data Dependency in popcnt.
Feb 16 2016
Feb 16 2016
AsafBadouh retitled D17289: [X86] Fix False Data Dependency in popcnt from to [X86] Fix False Data Dependency in popcnt.
Feb 10 2016
Feb 10 2016