Page MenuHomePhabricator

AsafBadouh (Asaf Badouh)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 4 2014, 1:36 AM (244 w, 6 d)

Recent Activity

Jan 24 2017

AsafBadouh updated the diff for D28354: [X86][MCU] replace select with bit manipulation instead of branches.

Great catch Igor,
the transformation is not valid to select (and (x & 0x1) == 0) , (z ^ y), y ),
for that we will need an extra instruction to create the mask.
I change the algorithm to catch only: select (and (x & 0x1) == 0) , y, (z ^ y) )

Jan 24 2017, 2:00 AM

Jan 15 2017

AsafBadouh updated the diff for D28354: [X86][MCU] replace select with bit manipulation instead of branches.

changes according to Igor review.

Jan 15 2017, 1:40 AM

Jan 12 2017

AsafBadouh added a comment to D28503: Documentation for the newly added x86 intrinsics..

LGTM

Jan 12 2017, 4:20 AM

Jan 5 2017

AsafBadouh retitled D28354: [X86][MCU] replace select with bit manipulation instead of branches from to [X86][MCU] replace select with bit manipulation instead of branches.
Jan 5 2017, 7:26 AM

Nov 27 2016

AsafBadouh added a reviewer for D26895: [X86][LMT] Restrict nop length to one: aaboud.
Nov 27 2016, 12:37 AM

Nov 20 2016

AsafBadouh retitled D26895: [X86][LMT] Restrict nop length to one from to [X86][LMT] Restrict nop length to one.
Nov 20 2016, 4:43 AM

Nov 10 2016

AsafBadouh updated the diff for D26449: DAGCombiner: fix combine of trunc and select.
  1. update the regression tests.
  2. used the utils/update_llc_test_checks.py to auto-generate complete checks.
Nov 10 2016, 8:47 AM
AsafBadouh updated the diff for D26449: DAGCombiner: fix combine of trunc and select.

+ Sanjay
fixes pr29002
update the test case using the example in pr29002

Nov 10 2016, 6:06 AM

Nov 9 2016

AsafBadouh updated the diff for D26449: DAGCombiner: fix combine of trunc and select.
Nov 9 2016, 6:59 AM
AsafBadouh retitled D26449: DAGCombiner: fix combine of trunc and select from to DAGCombiner: fix combine of trunc and select.
Nov 9 2016, 6:25 AM

Sep 11 2016

AsafBadouh accepted D24443: [AVX512] Fix pattern for vgetmantsd instruction.

LGTM

Sep 11 2016, 4:50 AM

Aug 21 2016

AsafBadouh updated D23753: [AVX512] Arguments to _mm512_[mask_]abs_ps|d must have "__" prefix .
Aug 21 2016, 12:44 AM
AsafBadouh retitled D23753: [AVX512] Arguments to _mm512_[mask_]abs_ps|d must have "__" prefix from to [AVX512] Arguments to _mm512_[mask_]abs_ps|d must have "__" prefix .
Aug 21 2016, 12:44 AM

Aug 14 2016

AsafBadouh accepted D23489: [AVX512] Fix VFPCLASSSD/VFPCLASSSS intrinsic lowering..

LGTM

Aug 14 2016, 6:51 AM

Aug 3 2016

AsafBadouh updated subscribers of D23108: Implemented 132/213/231 forms selection for X86-FMA3-AVX512 opcodes..
Aug 3 2016, 5:23 AM

Jul 11 2016

AsafBadouh retitled D22212: [X86][AVX512] Constants for integer comparison predicates from to [X86][AVX512] Constants for integer comparison predicates .
Jul 11 2016, 4:45 AM

Jul 5 2016

AsafBadouh added inline comments to D21973: [AVX512] add float/double abs intrinsics.
Jul 5 2016, 4:36 AM
AsafBadouh retitled D21988: [AVX512] minor fix in sqrt{ss|sd} intrinsics arguments from to [AVX512] minor fix in sqrt{ss|sd} intrinsics arguments.
Jul 5 2016, 4:30 AM
AsafBadouh added a reviewer for D21973: [AVX512] add float/double abs intrinsics: delena.
Jul 5 2016, 1:56 AM

Jul 4 2016

AsafBadouh retitled D21973: [AVX512] add float/double abs intrinsics from to [AVX512] add float/double abs intrinsics.
Jul 4 2016, 6:58 AM

Jun 26 2016

AsafBadouh updated the diff for D21504: [X86] add _mm_loadu_si64.
Jun 26 2016, 12:46 AM

Jun 23 2016

AsafBadouh updated the diff for D21504: [X86] add _mm_loadu_si64.

add align to CHECK

Jun 23 2016, 3:53 AM

Jun 19 2016

AsafBadouh updated the diff for D21504: [X86] add _mm_loadu_si64.

small changes according to Simon review.

Jun 19 2016, 8:22 AM
AsafBadouh retitled D21504: [X86] add _mm_loadu_si64 from to [X86] add _mm_loadu_si64.
Jun 19 2016, 6:06 AM

Jun 5 2016

AsafBadouh accepted D20866: [Clang][AVX512]Adding set4 intrinsics .

LGTM

Jun 5 2016, 7:07 AM

Jun 1 2016

AsafBadouh added inline comments to D20866: [Clang][AVX512]Adding set4 intrinsics .
Jun 1 2016, 7:27 AM
AsafBadouh accepted D20810: [Clang][Intrinsics][avx512] Continue Adding round cvt to clang.

minor fixes, LGTM

Jun 1 2016, 6:41 AM
AsafBadouh retitled D20861: [AVX512] add missing integer to float conversion from to [AVX512] add missing integer to float conversion.
Jun 1 2016, 5:46 AM

May 25 2016

AsafBadouh accepted D20562: [Clang][AVX512][BUILTIN] Adding intrinsics for set1 .

LGTM with small fix

May 25 2016, 6:35 AM
AsafBadouh accepted D20523: [Clang][AVX512][BUILTIN] Add missing intrinsics for cast . .

LGTM

May 25 2016, 6:30 AM
AsafBadouh accepted D19914: Adding front-end support to several intrinsics (bit scanning, conversion and state reading intrinsics).

LGTM

May 25 2016, 12:47 AM
AsafBadouh accepted D19915: Adding back-end support to two bit scanning intrinsics.

LGTM

May 25 2016, 12:36 AM

May 23 2016

AsafBadouh accepted D20521: [Clang][AVX512][Builtin] adding missing intrinsics for vpmultishiftqb{128|256|512} instruction set .

LGTM

May 23 2016, 6:21 AM
AsafBadouh updated the diff for D20518: [X86][RTM] _xabort() should not have "noreturn" attribute.

test added

May 23 2016, 1:37 AM
AsafBadouh added a reviewer for D20518: [X86][RTM] _xabort() should not have "noreturn" attribute: hliao.
May 23 2016, 12:54 AM
AsafBadouh retitled D20518: [X86][RTM] _xabort() should not have "noreturn" attribute from to [X86][RTM] _xabort() should not have "noreturn" attribute.
May 23 2016, 12:18 AM

May 19 2016

AsafBadouh accepted D20324: [Clang][AVX512][intrinsics] Fix vscalef intrinsics..

LGTM

May 19 2016, 6:56 AM
AsafBadouh accepted D20160: [Clang][AVX512][intrinsics] continue completing missing set intrinsics .

LGTM

May 19 2016, 12:45 AM

May 18 2016

AsafBadouh accepted D20101: [Clang][AVX512] completing missing intrinsics [pandnd]..

LGTM

May 18 2016, 6:34 AM
AsafBadouh added inline comments to D20101: [Clang][AVX512] completing missing intrinsics [pandnd]..
May 18 2016, 12:39 AM

May 10 2016

AsafBadouh accepted D20096: [Clang][AVX512] completing missing intrinsics for [vpermt2d|vptestm] instruction set..

LGTM

May 10 2016, 7:14 AM
AsafBadouh accepted D20063: [Clang][AVX512] completing missing intrinsics [load/store]..

LGTM

May 10 2016, 5:27 AM
AsafBadouh added inline comments to D20096: [Clang][AVX512] completing missing intrinsics for [vpermt2d|vptestm] instruction set..
May 10 2016, 5:24 AM
AsafBadouh added inline comments to D20063: [Clang][AVX512] completing missing intrinsics [load/store]..
May 10 2016, 1:27 AM
AsafBadouh accepted D20064: [Clang][AVX512] completing missing intrinsics [vmin/vmax]{sd|sq|uq|ud}..

LGTM

May 10 2016, 1:05 AM
AsafBadouh accepted D20061: [Clang][AVX512] completing missing intrinsics [vextractf]..

LGTM

May 10 2016, 12:56 AM

May 9 2016

AsafBadouh accepted D20062: [Clang][AVX512] completing missing intrinsics [vmin/vmax]..

LGTM

May 9 2016, 4:08 AM

May 8 2016

AsafBadouh added inline comments to D20055: [Clang][Intrinsics] Adding avx512f missing intrinsics {cast} .
May 8 2016, 5:08 AM

May 4 2016

AsafBadouh added inline comments to D19914: Adding front-end support to several intrinsics (bit scanning, conversion and state reading intrinsics).
May 4 2016, 7:24 AM
AsafBadouh added inline comments to D19915: Adding back-end support to two bit scanning intrinsics.
May 4 2016, 6:43 AM

May 3 2016

AsafBadouh accepted D19765: [Clang][Builtin][AVX512] Adding intrinsics fot cvt{u}si2s{d|s} cvt{sd|ss}2{ss|sd} instruction set .

LGTM

May 3 2016, 8:36 AM
AsafBadouh accepted D19858: [Clang][AVX512][BuiltIn] Adding intrinsics for cast{pd|ps|si}128_{pd|ps|si}512 and castsi256_si512 instruction set..

LTGM

May 3 2016, 4:21 AM
AsafBadouh accepted D19766: [Clang][avx512][Builtin] Adding intrinsics for cvtw2mask{128|256|512} instruction set.

LGTM

May 3 2016, 12:08 AM

May 2 2016

AsafBadouh added inline comments to D19765: [Clang][Builtin][AVX512] Adding intrinsics fot cvt{u}si2s{d|s} cvt{sd|ss}2{ss|sd} instruction set .
May 2 2016, 7:52 AM

May 1 2016

AsafBadouh accepted D19467: [Clang][avx512][builtin] Adding intrinsics for vexpand{d|q|ps|pd} instrctuon set .

LGTM

May 1 2016, 1:00 AM
AsafBadouh accepted D19580: [Clang][BuiltIn][avx512] Adding intrinsics for vpshufd instruction set .

lgtm

May 1 2016, 12:56 AM
AsafBadouh accepted D19595: [Clang][Builtin][AVX512] Adding intrinsics for vmovshdup and vmovsldup instruction set.

LGTM

May 1 2016, 12:53 AM

Apr 27 2016

AsafBadouh added a comment to D19467: [Clang][avx512][builtin] Adding intrinsics for vexpand{d|q|ps|pd} instrctuon set .

intrinsics with zero masks (maskz) are missing.

Apr 27 2016, 6:30 AM
AsafBadouh accepted D19588: [Clang][BuiltIn][AVX512] Adding intrinsics fot align{d|q} and palignr instruction set.

please change from setzero to undefined in the non mask versions.
LGTM after that.

Apr 27 2016, 6:24 AM

Apr 26 2016

AsafBadouh accepted D19529: [Clang][BuiltIn][AVX512]Adding intrinsics for vmovntdqa vmovntpd vmovntps instruction set.

minor fixes, LGTM

Apr 26 2016, 6:00 AM
AsafBadouh accepted D19525: [Clang][Builtin][AVX512] Adding intrisnics for the vpconflict{q|d} instruction set.

I just saw the dependency review, LGTM after it done.

Apr 26 2016, 3:32 AM
AsafBadouh added a comment to D19525: [Clang][Builtin][AVX512] Adding intrisnics for the vpconflict{q|d} instruction set.

you need to add avx512vlcdintrin.h to:

  • /lib/Headers/CMakeLists.txt
  • /lib/Headers/immintrin.h
Apr 26 2016, 3:30 AM

Apr 25 2016

AsafBadouh accepted D19466: [Clang][Builtin][AVX512]Adding k-register logic intrinsics KAND, KANDN, KOR, KORTEST, KXNOR, KXOR, KUNPACK instruction set. .

LGTM

Apr 25 2016, 5:33 AM
AsafBadouh accepted D19476: [Clang][Builtin][AVX512]Adding intrinsics for vfpclass{sd|ss} vfpclass{pd|ps} instruction set.

minor fixes, LGTM

Apr 25 2016, 5:16 AM
AsafBadouh added a comment to D19476: [Clang][Builtin][AVX512]Adding intrinsics for vfpclass{sd|ss} vfpclass{pd|ps} instruction set.

tests are missing

Apr 25 2016, 1:39 AM

Apr 24 2016

AsafBadouh accepted D19195: [Clang][AVX512][BuiltIn] Adding support to intrinsics of VPERMD and VPERMW instruction set .

LGTM

Apr 24 2016, 4:20 AM

Apr 21 2016

AsafBadouh added inline comments to D19040: Remove unnecessary load via GOT when accessing globals with PIE in x86_64.
Apr 21 2016, 1:17 AM

Apr 19 2016

AsafBadouh updated the diff for D19226: [X86] enable PIE for functions.

update according to Reid comments.

Apr 19 2016, 9:44 AM
AsafBadouh added inline comments to D19226: [X86] enable PIE for functions.
Apr 19 2016, 9:24 AM
AsafBadouh updated the diff for D19226: [X86] enable PIE for functions.

run clang-format and add other linkage testcases

Apr 19 2016, 3:26 AM
AsafBadouh added inline comments to D19226: [X86] enable PIE for functions.
Apr 19 2016, 3:24 AM

Apr 18 2016

AsafBadouh retitled D19226: [X86] enable PIE for functions from to [X86] enable PIE for functions.
Apr 18 2016, 9:09 AM
AsafBadouh added inline comments to D19195: [Clang][AVX512][BuiltIn] Adding support to intrinsics of VPERMD and VPERMW instruction set .
Apr 18 2016, 1:22 AM

Apr 17 2016

AsafBadouh accepted D19197: [Clang][Builtin][AVX512] Adding intrinsics for VGETMANT{PD|PS} and VGETEXP{PD|PS} instruction set.

LGTM

Apr 17 2016, 8:02 AM
AsafBadouh added inline comments to D19197: [Clang][Builtin][AVX512] Adding intrinsics for VGETMANT{PD|PS} and VGETEXP{PD|PS} instruction set.
Apr 17 2016, 7:51 AM
AsafBadouh added inline comments to D19195: [Clang][AVX512][BuiltIn] Adding support to intrinsics of VPERMD and VPERMW instruction set .
Apr 17 2016, 3:39 AM
AsafBadouh added inline comments to D19040: Remove unnecessary load via GOT when accessing globals with PIE in x86_64.
Apr 17 2016, 2:08 AM

Apr 13 2016

AsafBadouh added a comment to D18942: [X86] remove unneeded variables.

Hey Rafael,
can you please review this minor change?
Thanks,
Asaf

Apr 13 2016, 4:43 AM
AsafBadouh added a reviewer for D18942: [X86] remove unneeded variables: rafael.
Apr 13 2016, 4:42 AM

Apr 12 2016

AsafBadouh accepted D19009: [Clang][Builtin][AVX512] Adding builtin to clang . [cvt{b|d|q}2mask{128|256|512} cvtmask2{b|d|q}{128|256|512}] .

LGTM

Apr 12 2016, 4:52 AM
AsafBadouh added inline comments to D18861: [CLANG][AVX512][BUILTIN] Completing and Adding scalar Intrinsics to clang .
Apr 12 2016, 4:18 AM

Apr 11 2016

AsafBadouh accepted D18926: [Clang][AVX512][BuiltIn] Adding avx512 ( psll{d|q}512,psllv{16si|8di},psra{d|q}512,psrav{16si|8di},pternlog{d|q}{128|256|512} ) builtin to clang ....

LGTM

Apr 11 2016, 8:18 AM
AsafBadouh accepted D18930: Adding avx512 (shuf,sqrt{ss|sd},rsqrt ) builtin to clang .

LGTM

Apr 11 2016, 8:12 AM
AsafBadouh added a comment to D18926: [Clang][AVX512][BuiltIn] Adding avx512 ( psll{d|q}512,psllv{16si|8di},psra{d|q}512,psrav{16si|8di},pternlog{d|q}{128|256|512} ) builtin to clang ....

there are some tests duplication

Apr 11 2016, 4:21 AM
AsafBadouh updated subscribers of D18942: [X86] remove unneeded variables.
Apr 11 2016, 4:04 AM

Apr 10 2016

AsafBadouh added inline comments to D18930: Adding avx512 (shuf,sqrt{ss|sd},rsqrt ) builtin to clang .
Apr 10 2016, 8:28 AM
AsafBadouh retitled D18942: [X86] remove unneeded variables from to [X86] remove unneeded variables.
Apr 10 2016, 6:22 AM
AsafBadouh accepted D18924: [Clang][AVX512][BuiltIn] Adding avx512 ( ptest{n}m{b|w}{128|256|512} ) builtin to clang ...

see comments
LGTM

Apr 10 2016, 6:07 AM
AsafBadouh added a comment to D18926: [Clang][AVX512][BuiltIn] Adding avx512 ( psll{d|q}512,psllv{16si|8di},psra{d|q}512,psrav{16si|8di},pternlog{d|q}{128|256|512} ) builtin to clang ....

there are duplication in the headers and in the tests.

Apr 10 2016, 4:54 AM

Apr 3 2016

AsafBadouh added inline comments to D18446: [Clang][avx512][Builtin] Adding Builtin to clang. .
Apr 3 2016, 8:53 AM

Mar 28 2016

AsafBadouh accepted D18215: [CLANG][avx512][BUILTIN] Adding fixupimm{pd|ps|sd|ss} getexp{sd|ss} getmant{sd|ss} kunpck{di|si} loada{pd|ps} loaddqu{di|hi|qi|si} max{sd|ss} min{sd|ss} kmov16 builtins to clang.

LGTM

Mar 28 2016, 4:24 AM

Mar 17 2016

AsafBadouh accepted D18211: AVX512BW: Enable v32i1 BUILD_VECTOR.

LGTM

Mar 17 2016, 8:07 AM
AsafBadouh added inline comments to D18215: [CLANG][avx512][BUILTIN] Adding fixupimm{pd|ps|sd|ss} getexp{sd|ss} getmant{sd|ss} kunpck{di|si} loada{pd|ps} loaddqu{di|hi|qi|si} max{sd|ss} min{sd|ss} kmov16 builtins to clang.
Mar 17 2016, 7:48 AM

Mar 16 2016

AsafBadouh accepted D18204: AVX512BW : Fix SRA v64i8 lowering..

LGTM

Mar 16 2016, 1:00 AM

Feb 24 2016

AsafBadouh accepted D17538: [LLVM][AVX512][PSHUFHW ][PSHUFLW ] Change imm8 to int.

LGTM

Feb 24 2016, 12:07 AM

Feb 22 2016

AsafBadouh accepted D17498: AVX512F: Assembler Intel syntax..

LGTM

Feb 22 2016, 12:53 AM

Feb 18 2016

AsafBadouh accepted D16961: [CLANG] [AVX512] [BUILTIN] Adding pmovzx{b|d|w}{w|d|q}{128|256|512} builtin to clang .

LGTM

Feb 18 2016, 1:47 AM

Feb 17 2016

AsafBadouh added inline comments to D17289: [X86] Fix False Data Dependency in popcnt.
Feb 17 2016, 12:33 AM

Feb 16 2016

AsafBadouh retitled D17289: [X86] Fix False Data Dependency in popcnt from to [X86] Fix False Data Dependency in popcnt.
Feb 16 2016, 4:12 AM

Feb 10 2016

AsafBadouh added inline comments to D16985: [CLANG] [AVX512] [BUILTIN] Adding prol{d|q|w}{128|256|512} builtin to clang ..
Feb 10 2016, 12:42 AM