This is an archive of the discontinued LLVM Phabricator instance.

[mlir][AsmPrinter] Gracefully handle empty symbol
ClosedPublic

Authored by boschmitt on Jan 28 2023, 2:02 PM.

Details

Summary

The GenericOp printer should support malformed IR without crashing

GitHub issue #59529

Diff Detail

Event Timeline

boschmitt created this revision.Jan 28 2023, 2:02 PM
Herald added a project: Restricted Project. · View Herald Transcript
boschmitt requested review of this revision.Jan 28 2023, 2:02 PM
boschmitt edited the summary of this revision. (Show Details)Jan 28 2023, 2:03 PM
rriddle accepted this revision.Jan 28 2023, 2:09 PM
rriddle added inline comments.
mlir/lib/IR/AsmPrinter.cpp
2046
This revision is now accepted and ready to land.Jan 28 2023, 2:09 PM
boschmitt updated this revision to Diff 493033.Jan 28 2023, 2:18 PM

Don't change header includes. Add missing '@'

boschmitt marked an inline comment as done.Jan 30 2023, 10:55 AM

@rriddle, I forgot to mention (my apologies) that I don't have commit access, so I need help pushing the patch.

This revision was automatically updated to reflect the committed changes.