[GlobalISel] Don't combine instructions with unknown type in hoist_logic_op_with_same_opcode_hands.
ClosedPublic
Actions

Authored by dzhidzhoev on Jan 27 2023, 4:40 PM.

Details

Reviewers

paquette
arsenm
dsanders
aemerson

Commits

rG2a45d061ef81: [GlobalISel] Don't combine instructions with unknown type in…

Summary

This fixes failure for some LLVM IR.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

dzhidzhoev created this revision.Jan 27 2023, 4:40 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2023, 4:40 PM

Herald added a subscriber: hiraditya. · View Herald Transcript

dzhidzhoev requested review of this revision.Jan 27 2023, 4:40 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2023, 4:40 PM

Herald added subscribers: llvm-commits, wdng. · View Herald Transcript

paquette added inline comments.Jan 27 2023, 4:52 PM

llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
2753	Do you need to check for validity for both `XTy` and `YTy`?

Harbormaster completed remote builds in B210498: Diff 492948.Jan 27 2023, 6:07 PM

Addressed @paquette comment.

Harbormaster completed remote builds in B210509: Diff 492968.Jan 27 2023, 8:18 PM

LGTM

This revision is now accepted and ready to land.Jan 30 2023, 10:07 AM

Closed by commit rG2a45d061ef81: [GlobalISel] Don't combine instructions with unknown type in… (authored by dzhidzhoev). · Explain WhyJan 31 2023, 3:54 PM

This revision was automatically updated to reflect the committed changes.

dzhidzhoev added a commit: rG2a45d061ef81: [GlobalISel] Don't combine instructions with unknown type in….

Revision Contents
Changeset List

Path

Size

llvm/

lib/

CodeGen/

GlobalISel/

CombinerHelper.cpp

2 lines

test/

CodeGen/

AArch64/

GlobalISel/

postlegalizercombiner-hoist-same-hands.mir

17 lines

Diff 493759

View Options

llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp