Page MenuHomePhabricator
Differential D142690

[libc++] Fixes the Clang modular build.
ClosedPublic
Actions

Authored by Mordante on Jan 26 2023, 11:03 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGa7f8ddc4e2e3: [libc++] Fixes the Clang modular build.
Summary

The patch
430b397f6715d4d2f2569716c93fcd6292ace3dc ("[libc++] Granularize <type_traits> includes in <iterator>") missed some exports in the modulemap with became apparent in the reverting commit 12cb1cb3720d.

This fixes the issue by updating the modulemap. Note that the Clang ICE is not fixed by this change.

Diff Detail

Unit TestsFailed
View All

TimeTest
6,250 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx/gdb::gdb_pretty_printer_test.sh.cpp
Script: -- : 'RUN: at line 20'; /home/libcxx-builder/.buildkite-agent/builds/53f0b4343f2b-1/llvm-project/libcxx-ci/install/bin/clang++ --target=x86_64-unknown-linux-gnu /home/libcxx-builder/.buildkite-agent/builds/53f0b4343f2b-1/llvm-project/libcxx-ci/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp -o /home/libcxx-builder/.buildkite-agent/builds/53f0b4343f2b-1/llvm-project/libcxx-ci/build/generic-cxx2b/test/libcxx/gdb/Output/gdb_pretty_printer_test.sh.cpp.dir/t.tmp.exe -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/53f0b4343f2b-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/53f0b4343f2b-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/53f0b4343f2b-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -g -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/53f0b4343f2b-1/llvm-project/libcxx-ci/build/generic-cxx2b/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/53f0b4343f2b-1/llvm-project/libcxx-ci/build/generic-cxx2b/lib -lc++ -pthread
4,450 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/gdb::gdb_pretty_printer_test.sh.cpp
Script: -- : 'RUN: at line 20'; /home/libcxx-builder/.buildkite-agent/builds/d90c0ea7f664-1/llvm-project/libcxx-ci/install/bin/clang++ --target=x86_64-unknown-linux-gnu /home/libcxx-builder/.buildkite-agent/builds/d90c0ea7f664-1/llvm-project/libcxx-ci/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp -o /home/libcxx-builder/.buildkite-agent/builds/d90c0ea7f664-1/llvm-project/libcxx-ci/build/generic-modules/test/libcxx/gdb/Output/gdb_pretty_printer_test.sh.cpp.dir/t.tmp.exe -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/d90c0ea7f664-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/d90c0ea7f664-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/d90c0ea7f664-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -g -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/d90c0ea7f664-1/llvm-project/libcxx-ci/build/generic-modules/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/d90c0ea7f664-1/llvm-project/libcxx-ci/build/generic-modules/lib -lc++ -pthread

Event Timeline

Mordante created this revision.Jan 26 2023, 11:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2023, 11:03 PM
Mordante requested review of this revision.Jan 26 2023, 11:03 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 26 2023, 11:03 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, cfe-commits. · View Herald Transcript
Mordante added inline comments.Jan 26 2023, 11:05 PM
libcxx/include/module.modulemap.in
1421

Note this looks wrong from libc++'s perspective. When this "solves" the issue we need to investigate why it fixes it; I think the export belongs to a different header.

Mordante updated this revision to Diff 492648.Jan 26 2023, 11:08 PM

Fix CI run instead of libc++.

Herald added a subscriber: arichardson. · View Herald TranscriptJan 26 2023, 11:08 PM
Mordante mentioned this in rG12cb1cb3720d: Revert "[clang] Instantiate concepts with sugared template arguments".Jan 26 2023, 11:13 PM
Harbormaster completed remote builds in B210280: Diff 492648.Jan 26 2023, 11:40 PM
Mordante updated this revision to Diff 492779.Jan 27 2023, 8:45 AM

Rebased and improve fixes.

Harbormaster completed remote builds in B210377: Diff 492779.Jan 27 2023, 9:53 AM
Mordante updated this revision to Diff 492828.Jan 27 2023, 9:54 AM

Finalized patch.

Mordante updated this revision to Diff 492834.Jan 27 2023, 10:00 AM

Removes uninteded include.

Harbormaster completed remote builds in B210426: Diff 492834.Jan 27 2023, 10:47 AM
Mordante updated this revision to Diff 492999.Jan 28 2023, 6:39 AM

Undo CI changes.

Mordante retitled this revision from [DRAFT][libc++] Fixes the Clang modular build. to [libc++] Fixes the Clang modular build..Jan 28 2023, 6:51 AM
Mordante edited the summary of this revision. (Show Details)

https://buildkite.com/llvm-project/libcxx-ci/builds/18148 shows this patch fixes the Clang modular build.

Harbormaster completed remote builds in B210537: Diff 492999.Jan 28 2023, 8:10 AM
dblaikie added a subscriber: dblaikie.Jan 30 2023, 11:08 AM
ldionne accepted this revision.Jan 30 2023, 1:24 PM
This revision is now accepted and ready to land.Jan 30 2023, 1:24 PM
This revision was landed with ongoing or failed builds.Jan 31 2023, 10:20 AM
Closed by commit rGa7f8ddc4e2e3: [libc++] Fixes the Clang modular build. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rGa7f8ddc4e2e3: [libc++] Fixes the Clang modular build..

Revision Contents
Changeset List

PathSize
clang/
lib/
libcxx/
include/
5 lines
utils/
ci/
2 lines

Diff 492648

View Options

clang/lib/run_the_clang_CI

Loading...
View Options

libcxx/include/module.modulemap.in

Loading...
View Options

libcxx/utils/ci/generate-buildkite-pipeline

Loading...