This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Fix tensor shapes in Toy chapter 1
ClosedPublic

Authored by thopre on Jan 26 2023, 5:51 AM.

Details

Summary

In Toy tutorial chapter 1, multiply_transpose() is called with b<2, 3>
and c<3, 2> when both parameters should have the same shape. This commit
fixes this by instead using c and d as parameters and fix a comment typo
where c and d are mentioned to have shape <2, 2> when they actually have
shape <3, 2>.

Diff Detail

Event Timeline

thopre created this revision.Jan 26 2023, 5:51 AM
thopre requested review of this revision.Jan 26 2023, 5:51 AM
thopre retitled this revision from Fix tensor shapes in Toy chapter 1 to [MLIR] Fix tensor shapes in Toy chapter 1.Jan 26 2023, 5:54 AM
mehdi_amini accepted this revision.Jan 26 2023, 5:40 PM
This revision is now accepted and ready to land.Jan 26 2023, 5:40 PM
This revision was automatically updated to reflect the committed changes.