Previously when constraint system outputs the rows in the system the variables used are x1,2...n making it hard to infer which ones they relate to in the IR
Thanks for looking into this! Would it make sense to change ConstraintSystem to hold a pointer/reference to the corresponding variable map and then isolate the name generation logic and dumping to ConstraintSystem.cpp only?
Would it be possible to add a test to show the additional dbg output, e.g. llvm/test/Transforms/ConstraintElimination/debug.ll?
capitalize first letter of sentence and period at end of sentence. Newline before comment
Please run clang-format and remove the needed ;
Pass argument as const reference?
Can use (auto &[V, Index] : Value2Index).
This function isn't needed any longer.
Change to const reference and adjust name?
- Modify debug.ll test to display variable names.
- Delete unused functions and rename dumpdumpWithNames to dumpConstraint
- Address style comments
still needs a newline before the comment.
not just const, const reference, i.e. const DenseMap<Value *, unsigned> &Value2Index
newline before the next function.
; here also needs removed and reformatting. Please run clang-format.
The bit about using Names needs to be removed.
LGTM, with a few small nits addressed.
nit: from *the* Value2Index map.
nit: add newline here.
nit: the coding style recommends using auto sparingly and spell out full types unless they are too big. So here it would probably be better to use SmallVector<std::string>