This is an archive of the discontinued LLVM Phabricator instance.

Differential D142545

[ConstraintElimination] Add tests to check for `or` instruction decomposition if a constant operand is < 2^known_zero_bits of the first operand.
ClosedPublic

Authored by zjaffal on Jan 25 2023, 7:39 AM.

Details

Reviewers
fhahn
Commits
rGfa1eb2eb1606: [ConstraintElimination] Add tests to check for `or` instruction decomposition…

Diff Detail

Event Timeline

zjaffal created this revision.Jan 25 2023, 7:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2023, 7:39 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
zjaffal requested review of this revision.Jan 25 2023, 7:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2023, 7:39 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B209868: Diff 492107.Jan 25 2023, 8:35 AM
fhahn added a child revision: D142546: [ConstraintElimination] Decompose or instruction if the constant operand < 2^known_zero_bits of the first operand..Jan 26 2023, 3:50 AM
fhahn added inline comments.Jan 26 2023, 4:26 AM
llvm/test/Transforms/ConstraintElimination/or.ll
435

The names need updating I think to be more descriptive? There's just a single condition here and it would be good to make clear this tests or -> add conversion.

467

Maybe call the blocks just then and else?

Also, it would be good to add some checks in this block too, to make sure they don't get optimized.

fhahn requested changes to this revision.Feb 6 2023, 2:20 PM

Looks like this patch needs updating.

This revision now requires changes to proceed.Feb 6 2023, 2:20 PM
zjaffal updated this revision to Diff 496140.Feb 9 2023, 8:22 AM
  1. Update test names
  2. Add additional negative testcases
Harbormaster completed remote builds in B212822: Diff 496140.Feb 9 2023, 10:55 AM
fhahn accepted this revision.Feb 20 2023, 5:32 AM

LGTM, with the suggested additional cleanup

llvm/test/Transforms/ConstraintElimination/or.ll
471

Could you rename this variable? maybe %start.plus.3?

also, remove the dead %low argument.

This revision is now accepted and ready to land.Feb 20 2023, 5:32 AM
zjaffal marked 3 inline comments as done.Feb 20 2023, 6:09 AM
This revision was landed with ongoing or failed builds.Feb 20 2023, 6:39 AM
Closed by commit rGfa1eb2eb1606: [ConstraintElimination] Add tests to check for `or` instruction decomposition… (authored by zjaffal). · Explain Why
This revision was automatically updated to reflect the committed changes.
zjaffal added a commit: rGfa1eb2eb1606: [ConstraintElimination] Add tests to check for `or` instruction decomposition….
zjaffal removed a child revision: D142546: [ConstraintElimination] Decompose or instruction if the constant operand < 2^known_zero_bits of the first operand..Feb 20 2023, 6:55 AM

Revision Contents

PathSize
llvm/
test/
Transforms/
ConstraintElimination/
361 lines

Diff 498832

llvm/test/Transforms/ConstraintElimination/or.ll

Show First 20 Lines • Show All 425 Lines • ▼ Show 20 Linesexit:
%c.10 = icmp ule i4 2, %x %c.10 = icmp ule i4 2, %x
%res.8 = xor i1 %res.7, %c.10 %res.8 = xor i1 %res.7, %c.10
%c.11 = icmp ugt i4 2, %a %c.11 = icmp ugt i4 2, %a
%res.9 = xor i1 %res.8, %c.11 %res.9 = xor i1 %res.8, %c.11
ret i1 %res.9 ret i1 %res.9
} }
define void @test_or_as_add_ult(i8 %init_val, i8 %high) {
fhahnUnsubmitted
Done
ReplyInline Actions

The names need updating I think to be more descriptive? There's just a single condition here and it would be good to make clear this tests or -> add conversion.

fhahn: The names need updating I think to be more descriptive? There's just a single condition here…
; CHECK-LABEL: @test_or_as_add_ult(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[START:%.*]] = shl nuw nsw i8 [[INIT_VAL:%.*]], 2
; CHECK-NEXT: [[START_PLUS_3:%.*]] = add nuw i8 [[START]], 3
; CHECK-NEXT: [[C_1:%.*]] = icmp uge i8 [[START_PLUS_3]], [[HIGH:%.*]]
; CHECK-NEXT: br i1 [[C_1]], label [[THEN:%.*]], label [[END:%.*]]
; CHECK: then:
; CHECK-NEXT: [[F_0:%.*]] = icmp ult i8 [[START]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_0]])
; CHECK-NEXT: [[I_1:%.*]] = or i8 [[START]], 1
; CHECK-NEXT: [[F_1:%.*]] = icmp ult i8 [[I_1]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_1]])
; CHECK-NEXT: [[I_2:%.*]] = or i8 [[START]], 2
; CHECK-NEXT: [[F_2:%.*]] = icmp ult i8 [[I_2]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_2]])
; CHECK-NEXT: ret void
; CHECK: end:
; CHECK-NEXT: [[T_0:%.*]] = icmp ult i8 [[START]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 true)
; CHECK-NEXT: [[START_1:%.*]] = or i8 [[START]], 1
; CHECK-NEXT: [[T_1:%.*]] = icmp ult i8 [[START_1]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_1]])
; CHECK-NEXT: [[START_2:%.*]] = or i8 [[START]], 2
; CHECK-NEXT: [[T_2:%.*]] = icmp ult i8 [[START_2]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_2]])
; CHECK-NEXT: [[START_3:%.*]] = or i8 [[START]], 3
; CHECK-NEXT: [[T_3:%.*]] = icmp ult i8 [[START_3]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_3]])
; CHECK-NEXT: [[START_4:%.*]] = or i8 [[START]], 4
; CHECK-NEXT: [[C_4:%.*]] = icmp ult i8 [[START_4]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[C_4]])
; CHECK-NEXT: ret void
fhahnUnsubmitted
Done
ReplyInline Actions

Maybe call the blocks just then and else?

Also, it would be good to add some checks in this block too, to make sure they don't get optimized.

fhahn: Maybe call the blocks just `then` and `else`? Also, it would be good to add some checks in…
;
entry:
%start = shl nuw nsw i8 %init_val, 2
%start.plus.3 = add nuw i8 %start, 3
fhahnUnsubmitted
Done
ReplyInline Actions

Could you rename this variable? maybe %start.plus.3?

also, remove the dead %low argument.

fhahn: Could you rename this variable? maybe `%start.plus.3`? also, remove the dead `%low` argument.
%c.1 = icmp uge i8 %start.plus.3, %high
br i1 %c.1, label %then, label %end
then: ; preds = %entry
%f.0 = icmp ult i8 %start, %high
call void @use(i1 %f.0)
%i.1 = or i8 %start, 1
%f.1 = icmp ult i8 %i.1, %high
call void @use(i1 %f.1)
%i.2 = or i8 %start, 2
%f.2 = icmp ult i8 %i.2, %high
call void @use(i1 %f.2)
ret void
end: ; preds = %entry
%t.0 = icmp ult i8 %start, %high
call void @use(i1 %t.0)
%start.1 = or i8 %start, 1
%t.1 = icmp ult i8 %start.1, %high
call void @use(i1 %t.1)
%start.2 = or i8 %start, 2
%t.2 = icmp ult i8 %start.2, %high
call void @use(i1 %t.2)
%start.3 = or i8 %start, 3
%t.3 = icmp ult i8 %start.3, %high
call void @use(i1 %t.3)
%start.4 = or i8 %start, 4
%c.4 = icmp ult i8 %start.4, %high
call void @use(i1 %c.4)
ret void
}
define void @test_or_as_add_ule(i8 %init_val, i8 %high) {
; CHECK-LABEL: @test_or_as_add_ule(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[START:%.*]] = shl nuw nsw i8 [[INIT_VAL:%.*]], 2
; CHECK-NEXT: [[START_PLUS_3:%.*]] = add nuw i8 [[START]], 3
; CHECK-NEXT: [[C_1:%.*]] = icmp uge i8 [[START_PLUS_3]], [[HIGH:%.*]]
; CHECK-NEXT: br i1 [[C_1]], label [[THEN:%.*]], label [[END:%.*]]
; CHECK: then:
; CHECK-NEXT: [[F_0:%.*]] = icmp ule i8 [[START]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_0]])
; CHECK-NEXT: [[I_1:%.*]] = or i8 [[START]], 1
; CHECK-NEXT: [[F_1:%.*]] = icmp ule i8 [[I_1]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_1]])
; CHECK-NEXT: [[I_2:%.*]] = or i8 [[START]], 2
; CHECK-NEXT: [[F_2:%.*]] = icmp ule i8 [[I_2]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_2]])
; CHECK-NEXT: ret void
; CHECK: end:
; CHECK-NEXT: [[T_0:%.*]] = icmp ule i8 [[START]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 true)
; CHECK-NEXT: [[START_1:%.*]] = or i8 [[START]], 1
; CHECK-NEXT: [[T_1:%.*]] = icmp ule i8 [[START_1]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_1]])
; CHECK-NEXT: [[START_2:%.*]] = or i8 [[START]], 2
; CHECK-NEXT: [[T_2:%.*]] = icmp ule i8 [[START_2]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_2]])
; CHECK-NEXT: [[START_3:%.*]] = or i8 [[START]], 3
; CHECK-NEXT: [[T_3:%.*]] = icmp ule i8 [[START_3]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_3]])
; CHECK-NEXT: [[START_4:%.*]] = or i8 [[START]], 4
; CHECK-NEXT: [[T_4:%.*]] = icmp ule i8 [[START_4]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_4]])
; CHECK-NEXT: [[START_5:%.*]] = or i8 [[START]], 5
; CHECK-NEXT: [[C_5:%.*]] = icmp ule i8 [[START_5]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[C_5]])
; CHECK-NEXT: ret void
;
entry:
%start = shl nuw nsw i8 %init_val, 2
%start.plus.3 = add nuw i8 %start, 3
%c.1 = icmp uge i8 %start.plus.3, %high
br i1 %c.1, label %then, label %end
then: ; preds = %entry
%f.0 = icmp ule i8 %start, %high
call void @use(i1 %f.0)
%i.1 = or i8 %start, 1
%f.1 = icmp ule i8 %i.1, %high
call void @use(i1 %f.1)
%i.2 = or i8 %start, 2
%f.2 = icmp ule i8 %i.2, %high
call void @use(i1 %f.2)
ret void
end: ; preds = %entry
%t.0 = icmp ule i8 %start, %high
call void @use(i1 %t.0)
%start.1 = or i8 %start, 1
%t.1 = icmp ule i8 %start.1, %high
call void @use(i1 %t.1)
%start.2 = or i8 %start, 2
%t.2 = icmp ule i8 %start.2, %high
call void @use(i1 %t.2)
%start.3 = or i8 %start, 3
%t.3 = icmp ule i8 %start.3, %high
call void @use(i1 %t.3)
%start.4 = or i8 %start, 4
%t.4 = icmp ule i8 %start.4, %high
call void @use(i1 %t.4)
%start.5 = or i8 %start, 5
%c.5 = icmp ule i8 %start.5, %high
call void @use(i1 %c.5)
ret void
}
define void @test_or_as_add_ugt(i8 %init_val, i8 %high) {
; CHECK-LABEL: @test_or_as_add_ugt(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[START:%.*]] = shl nuw nsw i8 [[INIT_VAL:%.*]], 2
; CHECK-NEXT: [[START_PLUS_3:%.*]] = add nuw i8 [[START]], 3
; CHECK-NEXT: [[C_1:%.*]] = icmp uge i8 [[START_PLUS_3]], [[HIGH:%.*]]
; CHECK-NEXT: br i1 [[C_1]], label [[THEN:%.*]], label [[END:%.*]]
; CHECK: then:
; CHECK-NEXT: [[T_0:%.*]] = icmp ugt i8 [[START]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_0]])
; CHECK-NEXT: [[I_1:%.*]] = or i8 [[START]], 1
; CHECK-NEXT: [[T_1:%.*]] = icmp ugt i8 [[I_1]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_1]])
; CHECK-NEXT: [[I_2:%.*]] = or i8 [[START]], 2
; CHECK-NEXT: [[T_2:%.*]] = icmp ugt i8 [[I_2]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_2]])
; CHECK-NEXT: ret void
; CHECK: end:
; CHECK-NEXT: [[F_0:%.*]] = icmp ugt i8 [[START]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 false)
; CHECK-NEXT: [[START_1:%.*]] = or i8 [[START]], 1
; CHECK-NEXT: [[F_1:%.*]] = icmp ugt i8 [[START_1]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_1]])
; CHECK-NEXT: [[START_2:%.*]] = or i8 [[START]], 2
; CHECK-NEXT: [[F_2:%.*]] = icmp ugt i8 [[START_2]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_2]])
; CHECK-NEXT: [[START_3:%.*]] = or i8 [[START]], 3
; CHECK-NEXT: [[F_3:%.*]] = icmp ugt i8 [[START_3]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_3]])
; CHECK-NEXT: [[START_4:%.*]] = or i8 [[START]], 4
; CHECK-NEXT: [[F_4:%.*]] = icmp ugt i8 [[START_4]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_4]])
; CHECK-NEXT: [[START_5:%.*]] = or i8 [[START]], 5
; CHECK-NEXT: [[C_5:%.*]] = icmp ugt i8 [[START_5]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[C_5]])
; CHECK-NEXT: ret void
;
entry:
%start = shl nuw nsw i8 %init_val, 2
%start.plus.3 = add nuw i8 %start, 3
%c.1 = icmp uge i8 %start.plus.3, %high
br i1 %c.1, label %then, label %end
then: ; preds = %entry
%t.0 = icmp ugt i8 %start, %high
call void @use(i1 %t.0)
%i.1 = or i8 %start, 1
%t.1 = icmp ugt i8 %i.1, %high
call void @use(i1 %t.1)
%i.2 = or i8 %start, 2
%t.2 = icmp ugt i8 %i.2, %high
call void @use(i1 %t.2)
ret void
end: ; preds = %entry
%f.0 = icmp ugt i8 %start, %high
call void @use(i1 %f.0)
%start.1 = or i8 %start, 1
%f.1 = icmp ugt i8 %start.1, %high
call void @use(i1 %f.1)
%start.2 = or i8 %start, 2
%f.2 = icmp ugt i8 %start.2, %high
call void @use(i1 %f.2)
%start.3 = or i8 %start, 3
%f.3 = icmp ugt i8 %start.3, %high
call void @use(i1 %f.3)
%start.4 = or i8 %start, 4
%f.4 = icmp ugt i8 %start.4, %high
call void @use(i1 %f.4)
%start.5 = or i8 %start, 5
%c.5 = icmp ugt i8 %start.5, %high
call void @use(i1 %c.5)
ret void
}
define void @test_or_as_add_uge(i8 %init_val, i8 %high) {
; CHECK-LABEL: @test_or_as_add_uge(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[START:%.*]] = shl nuw nsw i8 [[INIT_VAL:%.*]], 2
; CHECK-NEXT: [[START_PLUS_3:%.*]] = add nuw i8 [[START]], 3
; CHECK-NEXT: [[C_1:%.*]] = icmp uge i8 [[START_PLUS_3]], [[HIGH:%.*]]
; CHECK-NEXT: br i1 [[C_1]], label [[THEN:%.*]], label [[END:%.*]]
; CHECK: then:
; CHECK-NEXT: [[T_0:%.*]] = icmp ugt i8 [[START]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_0]])
; CHECK-NEXT: [[I_1:%.*]] = or i8 [[START]], 1
; CHECK-NEXT: [[T_1:%.*]] = icmp uge i8 [[I_1]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_1]])
; CHECK-NEXT: [[I_2:%.*]] = or i8 [[START]], 2
; CHECK-NEXT: [[T_2:%.*]] = icmp uge i8 [[I_2]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_2]])
; CHECK-NEXT: ret void
; CHECK: end:
; CHECK-NEXT: [[F_0:%.*]] = icmp ugt i8 [[START]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 false)
; CHECK-NEXT: [[START_1:%.*]] = or i8 [[START]], 1
; CHECK-NEXT: [[F_1:%.*]] = icmp uge i8 [[START_1]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_1]])
; CHECK-NEXT: [[START_2:%.*]] = or i8 [[START]], 2
; CHECK-NEXT: [[F_2:%.*]] = icmp uge i8 [[START_2]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_2]])
; CHECK-NEXT: [[START_3:%.*]] = or i8 [[START]], 3
; CHECK-NEXT: [[F_3:%.*]] = icmp uge i8 [[START_3]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_3]])
; CHECK-NEXT: [[START_4:%.*]] = or i8 [[START]], 4
; CHECK-NEXT: [[C_4:%.*]] = icmp uge i8 [[START_4]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[C_4]])
; CHECK-NEXT: [[START_5:%.*]] = or i8 [[START]], 5
; CHECK-NEXT: [[C_5:%.*]] = icmp uge i8 [[START_5]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[C_5]])
; CHECK-NEXT: ret void
;
entry:
%start = shl nuw nsw i8 %init_val, 2
%start.plus.3 = add nuw i8 %start, 3
%c.1 = icmp uge i8 %start.plus.3, %high
br i1 %c.1, label %then, label %end
then: ; preds = %entry
%t.0 = icmp ugt i8 %start, %high
call void @use(i1 %t.0)
%i.1 = or i8 %start, 1
%t.1 = icmp uge i8 %i.1, %high
call void @use(i1 %t.1)
%i.2 = or i8 %start, 2
%t.2 = icmp uge i8 %i.2, %high
call void @use(i1 %t.2)
ret void
end: ; preds = %entry
%f.0 = icmp ugt i8 %start, %high
call void @use(i1 %f.0)
%start.1 = or i8 %start, 1
%f.1 = icmp uge i8 %start.1, %high
call void @use(i1 %f.1)
%start.2 = or i8 %start, 2
%f.2 = icmp uge i8 %start.2, %high
call void @use(i1 %f.2)
%start.3 = or i8 %start, 3
%f.3 = icmp uge i8 %start.3, %high
call void @use(i1 %f.3)
%start.4 = or i8 %start, 4
%c.4 = icmp uge i8 %start.4, %high
call void @use(i1 %c.4)
%start.5 = or i8 %start, 5
%c.5 = icmp uge i8 %start.5, %high
call void @use(i1 %c.5)
ret void
}
define void @test_not_decompose(i8 %start, i8 %high) {
; CHECK-LABEL: @test_not_decompose(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[START_PLUS_3:%.*]] = add nuw i8 [[START:%.*]], 3
; CHECK-NEXT: [[C_1:%.*]] = icmp uge i8 [[START_PLUS_3]], [[HIGH:%.*]]
; CHECK-NEXT: br i1 [[C_1]], label [[THEN:%.*]], label [[END:%.*]]
; CHECK: then:
; CHECK-NEXT: [[I_1:%.*]] = or i8 [[START]], 1
; CHECK-NEXT: [[T_1:%.*]] = icmp uge i8 [[I_1]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_1]])
; CHECK-NEXT: [[I_2:%.*]] = or i8 [[START]], 2
; CHECK-NEXT: [[T_2:%.*]] = icmp uge i8 [[I_2]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[T_2]])
; CHECK-NEXT: ret void
; CHECK: end:
; CHECK-NEXT: [[START_1:%.*]] = or i8 [[START]], 1
; CHECK-NEXT: [[F_1:%.*]] = icmp uge i8 [[START_1]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_1]])
; CHECK-NEXT: [[START_2:%.*]] = or i8 [[START]], 2
; CHECK-NEXT: [[F_2:%.*]] = icmp uge i8 [[START_2]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_2]])
; CHECK-NEXT: [[START_3:%.*]] = or i8 [[START]], 3
; CHECK-NEXT: [[F_3:%.*]] = icmp uge i8 [[START_3]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[F_3]])
; CHECK-NEXT: [[START_4:%.*]] = or i8 [[START]], 4
; CHECK-NEXT: [[C_4:%.*]] = icmp uge i8 [[START_4]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[C_4]])
; CHECK-NEXT: [[START_5:%.*]] = or i8 [[START]], 5
; CHECK-NEXT: [[C_5:%.*]] = icmp uge i8 [[START_5]], [[HIGH]]
; CHECK-NEXT: call void @use(i1 [[C_5]])
; CHECK-NEXT: ret void
;
entry:
%start.plus.3 = add nuw i8 %start, 3
%c.1 = icmp uge i8 %start.plus.3, %high
br i1 %c.1, label %then, label %end
then: ; preds = %entry
%i.1 = or i8 %start, 1
%t.1 = icmp uge i8 %i.1, %high
call void @use(i1 %t.1)
%i.2 = or i8 %start, 2
%t.2 = icmp uge i8 %i.2, %high
call void @use(i1 %t.2)
ret void
end: ; preds = %entry
%start.1 = or i8 %start, 1
%f.1 = icmp uge i8 %start.1, %high
call void @use(i1 %f.1)
%start.2 = or i8 %start, 2
%f.2 = icmp uge i8 %start.2, %high
call void @use(i1 %f.2)
%start.3 = or i8 %start, 3
%f.3 = icmp uge i8 %start.3, %high
call void @use(i1 %f.3)
%start.4 = or i8 %start, 4
%c.4 = icmp uge i8 %start.4, %high
call void @use(i1 %c.4)
%start.5 = or i8 %start, 5
%c.5 = icmp uge i8 %start.5, %high
call void @use(i1 %c.5)
ret void
}