Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
llvm/test/Transforms/ConstraintElimination/or.ll | ||
---|---|---|
435 | The names need updating I think to be more descriptive? There's just a single condition here and it would be good to make clear this tests or -> add conversion. | |
467 | Maybe call the blocks just then and else? Also, it would be good to add some checks in this block too, to make sure they don't get optimized. |
Comment Actions
LGTM, with the suggested additional cleanup
llvm/test/Transforms/ConstraintElimination/or.ll | ||
---|---|---|
471 | Could you rename this variable? maybe %start.plus.3? also, remove the dead %low argument. |
The names need updating I think to be more descriptive? There's just a single condition here and it would be good to make clear this tests or -> add conversion.