This is an archive of the discontinued LLVM Phabricator instance.

Differential D142537

[AMDGPU] sendmsg(MSG_ORDERED_PS_DONE) is not supported on GFX11
ClosedPublic

Authored by foad on Jan 25 2023, 6:36 AM.

Details

Reviewers
dstuttard
Group Reviewers
Restricted Project
Commits
rGa420ba9522f9: [AMDGPU] sendmsg(MSG_ORDERED_PS_DONE) is not supported on GFX11

Diff Detail

Event Timeline

foad created this revision.Jan 25 2023, 6:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2023, 6:36 AM
Herald added subscribers: kosarev, StephenFan, kerbowa and 7 others. · View Herald Transcript
foad requested review of this revision.Jan 25 2023, 6:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2023, 6:36 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Harbormaster completed remote builds in B209855: Diff 492090.Jan 25 2023, 7:41 AM
dstuttard accepted this revision.Jan 26 2023, 12:45 AM

LGTM

This revision is now accepted and ready to land.Jan 26 2023, 12:45 AM
This revision was landed with ongoing or failed builds.Jan 26 2023, 12:56 AM
Closed by commit rGa420ba9522f9: [AMDGPU] sendmsg(MSG_ORDERED_PS_DONE) is not supported on GFX11 (authored by foad). · Explain Why
This revision was automatically updated to reflect the committed changes.
foad added a commit: rGa420ba9522f9: [AMDGPU] sendmsg(MSG_ORDERED_PS_DONE) is not supported on GFX11.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
2 lines
Utils/
2 lines
test/
MC/
AMDGPU/
1 line

Diff 492349

llvm/lib/Target/AMDGPU/SIDefines.h

Show First 20 Lines • Show All 327 Lines • ▼ Show 20 Linesenum Id { // Message ID, width(4) [3:0].
ID_GS_DONE_PreGFX11 = 3, // replaced in GFX11 ID_GS_DONE_PreGFX11 = 3, // replaced in GFX11
ID_HS_TESSFACTOR_GFX11Plus = 2, // reused in GFX11 ID_HS_TESSFACTOR_GFX11Plus = 2, // reused in GFX11
ID_DEALLOC_VGPRS_GFX11Plus = 3, // reused in GFX11 ID_DEALLOC_VGPRS_GFX11Plus = 3, // reused in GFX11
ID_SAVEWAVE = 4, // added in GFX8, removed in GFX11 ID_SAVEWAVE = 4, // added in GFX8, removed in GFX11
ID_STALL_WAVE_GEN = 5, // added in GFX9 ID_STALL_WAVE_GEN = 5, // added in GFX9
ID_HALT_WAVES = 6, // added in GFX9 ID_HALT_WAVES = 6, // added in GFX9
ID_ORDERED_PS_DONE = 7, // added in GFX9 ID_ORDERED_PS_DONE = 7, // added in GFX9, removed in GFX11
ID_EARLY_PRIM_DEALLOC = 8, // added in GFX9, removed in GFX10 ID_EARLY_PRIM_DEALLOC = 8, // added in GFX9, removed in GFX10
ID_GS_ALLOC_REQ = 9, // added in GFX9 ID_GS_ALLOC_REQ = 9, // added in GFX9
ID_GET_DOORBELL = 10, // added in GFX9, removed in GFX11 ID_GET_DOORBELL = 10, // added in GFX9, removed in GFX11
ID_GET_DDID = 11, // added in GFX10, removed in GFX11 ID_GET_DDID = 11, // added in GFX10, removed in GFX11
ID_SYSMSG = 15, ID_SYSMSG = 15,
ID_RTN_GET_DOORBELL = 128, ID_RTN_GET_DOORBELL = 128,
ID_RTN_GET_DDID = 129, ID_RTN_GET_DDID = 129,
▲ Show 20 Lines • Show All 722 Lines • Show Last 20 Lines

llvm/lib/Target/AMDGPU/Utils/AMDGPUAsmUtils.cpp

Show All 38 Lines
const CustomOperand<const MCSubtargetInfo &> Msg[] = { const CustomOperand<const MCSubtargetInfo &> Msg[] = {
{{""}}, {{""}},
{{"MSG_INTERRUPT"}, ID_INTERRUPT}, {{"MSG_INTERRUPT"}, ID_INTERRUPT},
{{"MSG_GS"}, ID_GS_PreGFX11, isNotGFX11Plus}, {{"MSG_GS"}, ID_GS_PreGFX11, isNotGFX11Plus},
{{"MSG_GS_DONE"}, ID_GS_DONE_PreGFX11, isNotGFX11Plus}, {{"MSG_GS_DONE"}, ID_GS_DONE_PreGFX11, isNotGFX11Plus},
{{"MSG_SAVEWAVE"}, ID_SAVEWAVE, isGFX8_GFX9_GFX10}, {{"MSG_SAVEWAVE"}, ID_SAVEWAVE, isGFX8_GFX9_GFX10},
{{"MSG_STALL_WAVE_GEN"}, ID_STALL_WAVE_GEN, isGFX9Plus}, {{"MSG_STALL_WAVE_GEN"}, ID_STALL_WAVE_GEN, isGFX9Plus},
{{"MSG_HALT_WAVES"}, ID_HALT_WAVES, isGFX9Plus}, {{"MSG_HALT_WAVES"}, ID_HALT_WAVES, isGFX9Plus},
{{"MSG_ORDERED_PS_DONE"}, ID_ORDERED_PS_DONE, isGFX9Plus}, {{"MSG_ORDERED_PS_DONE"}, ID_ORDERED_PS_DONE, isGFX9_GFX10},
{{"MSG_EARLY_PRIM_DEALLOC"}, ID_EARLY_PRIM_DEALLOC, isGFX9_GFX10}, {{"MSG_EARLY_PRIM_DEALLOC"}, ID_EARLY_PRIM_DEALLOC, isGFX9_GFX10},
{{"MSG_GS_ALLOC_REQ"}, ID_GS_ALLOC_REQ, isGFX9Plus}, {{"MSG_GS_ALLOC_REQ"}, ID_GS_ALLOC_REQ, isGFX9Plus},
{{"MSG_GET_DOORBELL"}, ID_GET_DOORBELL, isGFX9_GFX10}, {{"MSG_GET_DOORBELL"}, ID_GET_DOORBELL, isGFX9_GFX10},
{{"MSG_GET_DDID"}, ID_GET_DDID, isGFX10}, {{"MSG_GET_DDID"}, ID_GET_DDID, isGFX10},
{{"MSG_HS_TESSFACTOR"}, ID_HS_TESSFACTOR_GFX11Plus, isGFX11Plus}, {{"MSG_HS_TESSFACTOR"}, ID_HS_TESSFACTOR_GFX11Plus, isGFX11Plus},
{{"MSG_DEALLOC_VGPRS"}, ID_DEALLOC_VGPRS_GFX11Plus, isGFX11Plus}, {{"MSG_DEALLOC_VGPRS"}, ID_DEALLOC_VGPRS_GFX11Plus, isGFX11Plus},
{{""}}, {{""}},
{{"MSG_SYSMSG"}, ID_SYSMSG}, {{"MSG_SYSMSG"}, ID_SYSMSG},
▲ Show 20 Lines • Show All 514 Lines • Show Last 20 Lines

llvm/test/MC/AMDGPU/sopp-err.s

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Lines
s_sendmsg sendmsg(MSG_HALT_WAVES) s_sendmsg sendmsg(MSG_HALT_WAVES)
// SICI: :[[@LINE-1]]:{{[0-9]+}}: error: specified message id is not supported on this GPU // SICI: :[[@LINE-1]]:{{[0-9]+}}: error: specified message id is not supported on this GPU
// VI: :[[@LINE-2]]:{{[0-9]+}}: error: specified message id is not supported on this GPU // VI: :[[@LINE-2]]:{{[0-9]+}}: error: specified message id is not supported on this GPU
s_sendmsg sendmsg(MSG_ORDERED_PS_DONE) s_sendmsg sendmsg(MSG_ORDERED_PS_DONE)
// SICI: :[[@LINE-1]]:{{[0-9]+}}: error: specified message id is not supported on this GPU // SICI: :[[@LINE-1]]:{{[0-9]+}}: error: specified message id is not supported on this GPU
// VI: :[[@LINE-2]]:{{[0-9]+}}: error: specified message id is not supported on this GPU // VI: :[[@LINE-2]]:{{[0-9]+}}: error: specified message id is not supported on this GPU
// GFX11: :[[@LINE-3]]:{{[0-9]+}}: error: specified message id is not supported on this GPU
s_sendmsg sendmsg(MSG_EARLY_PRIM_DEALLOC) s_sendmsg sendmsg(MSG_EARLY_PRIM_DEALLOC)
// SICI: :[[@LINE-1]]:{{[0-9]+}}: error: specified message id is not supported on this GPU // SICI: :[[@LINE-1]]:{{[0-9]+}}: error: specified message id is not supported on this GPU
// VI: :[[@LINE-2]]:{{[0-9]+}}: error: specified message id is not supported on this GPU // VI: :[[@LINE-2]]:{{[0-9]+}}: error: specified message id is not supported on this GPU
// GFX11: :[[@LINE-3]]:{{[0-9]+}}: error: specified message id is not supported on this GPU // GFX11: :[[@LINE-3]]:{{[0-9]+}}: error: specified message id is not supported on this GPU
s_sendmsg sendmsg(MSG_GS_ALLOC_REQ) s_sendmsg sendmsg(MSG_GS_ALLOC_REQ)
// VI: :[[@LINE-1]]:{{[0-9]+}}: error: specified message id is not supported on this GPU // VI: :[[@LINE-1]]:{{[0-9]+}}: error: specified message id is not supported on this GPU
▲ Show 20 Lines • Show All 319 Lines • Show Last 20 Lines