These address some remaining reasons to #include StdSymbolMap.inc directly.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Paths
| Differential D142467
[Tooling] Add stdlib::Symbol::all() and stdlib::Symbol::qualified_name() ClosedPublic Authored by sammccall on Jan 24 2023, 6:40 AM.
Details Summary These address some remaining reasons to #include StdSymbolMap.inc directly.
Diff Detail
Event Timelinehokein added inline comments. This revision is now accepted and ready to land.Feb 3 2023, 1:56 AM sammccall added inline comments. This revision was landed with ongoing or failed builds.Feb 3 2023, 4:22 AM Closed by commit rGe1aaa314a46c: [Tooling] Add stdlib::Symbol::all() and stdlib::Symbol::qualified_name() (authored by sammccall). · Explain Why This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done.
Revision Contents
Diff 494587 clang/include/clang/Tooling/Inclusions/StandardLibrary.h
clang/lib/Sema/SemaDecl.cpp
clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp
clang/test/AST/dump.cpp
clang/unittests/Tooling/StandardLibraryTest.cpp
|
nit: we group five symbols together, it is a bit hard to follow.
Can you move the HeaderNames just before the HeaderIDs and mention the value of the HeaderIDs is the index of HeaderNames?