This is an archive of the discontinued LLVM Phabricator instance.

[Tooling] Add stdlib::Symbol::all() and stdlib::Symbol::qualified_name()
ClosedPublic

Authored by sammccall on Jan 24 2023, 6:40 AM.

Details

Summary

These address some remaining reasons to #include StdSymbolMap.inc directly.

Diff Detail

Event Timeline

sammccall created this revision.Jan 24 2023, 6:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 6:40 AM
sammccall requested review of this revision.Jan 24 2023, 6:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 6:40 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sammccall updated this revision to Diff 491766.Jan 24 2023, 7:00 AM

oops, helps if I run tests on the right branch

hokein accepted this revision.Feb 3 2023, 1:56 AM
hokein added inline comments.
clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp
19

nit: we group five symbols together, it is a bit hard to follow.

Can you move the HeaderNames just before the HeaderIDs and mention the value of the HeaderIDs is the index of HeaderNames?

113

should be SymbolCount.

This revision is now accepted and ready to land.Feb 3 2023, 1:56 AM
sammccall marked 2 inline comments as done.Feb 3 2023, 3:58 AM
sammccall added inline comments.
clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp
19

Rearranged these and added comments to each.

113

Oops, thanks!

This revision was landed with ongoing or failed builds.Feb 3 2023, 4:22 AM
This revision was automatically updated to reflect the committed changes.
sammccall marked 2 inline comments as done.