This is an archive of the discontinued LLVM Phabricator instance.

[llvm] Do not zero out write_unsigned_impl internal buffer
ClosedPublic

Authored by serge-sans-paille on Jan 24 2023, 6:08 AM.

Details

Summary

Current implementation uselessly calls memset on its internal buffer
while it does not read the non overwritten part.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 6:08 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
serge-sans-paille requested review of this revision.Jan 24 2023, 6:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 6:08 AM
mehdi_amini accepted this revision.Jan 25 2023, 4:33 PM

How did you find this? Just random audit of the code?

This revision is now accepted and ready to land.Jan 25 2023, 4:33 PM

How did you find this? Just random audit of the code?

It started with random profiling and then I stumbled on that function and then...

This revision was landed with ongoing or failed builds.Jan 25 2023, 10:59 PM
This revision was automatically updated to reflect the committed changes.