Current implementation uselessly calls memset on its internal buffer
while it does not read the non overwritten part.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Paths
| Differential D142464
[llvm] Do not zero out write_unsigned_impl internal buffer ClosedPublic Authored by serge-sans-paille on Jan 24 2023, 6:08 AM.
Details Summary Current implementation uselessly calls memset on its internal buffer
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Jan 25 2023, 4:33 PM Comment Actions
It started with random profiling and then I stumbled on that function and then... This revision was landed with ongoing or failed builds.Jan 25 2023, 10:59 PM Closed by commit rG8f79b0fe0047: [llvm] Do not zero out write_unsigned_impl internal buffer (authored by serge-sans-paille). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 492340 llvm/lib/Support/NativeFormatting.cpp
llvm/unittests/Support/NativeFormatTests.cpp
|