This is an archive of the discontinued LLVM Phabricator instance.

[clang][Interp] Handle TypeTraitExprs
ClosedPublic

Authored by tbaeder on Jan 24 2023, 3:14 AM.

Details

Summary

Only light testing here, since the value we're emitting is something we get from sema IIUC.

Diff Detail

Event Timeline

tbaeder created this revision.Jan 24 2023, 3:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 3:14 AM
tbaeder requested review of this revision.Jan 24 2023, 3:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 3:14 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaron.ballman accepted this revision.Feb 2 2023, 11:02 AM

LGTM assuming there are no surprises from the additional test request.

clang/test/AST/Interp/literals.cpp
756

I'd like to see a test where the argument is value dependent: https://godbolt.org/z/a1W68vhh7

This revision is now accepted and ready to land.Feb 2 2023, 11:02 AM
tbaeder updated this revision to Diff 494504.Feb 2 2023, 9:44 PM
tbaeder marked an inline comment as done.

Nope, no surprises.

shafik accepted this revision.Feb 16 2023, 7:47 PM
This revision was landed with ongoing or failed builds.Mar 31 2023, 6:55 AM
This revision was automatically updated to reflect the committed changes.