This is an archive of the discontinued LLVM Phabricator instance.

Differential D142362

[cmake] Remove AddLLVMDefinitions
ClosedPublic

Authored by foad on Jan 23 2023, 7:01 AM.

Details

Reviewers
sepavloff
beanz
mgorny
Commits
rGcdb226433f1b: [cmake] Remove AddLLVMDefinitions
Summary

This has been unused since D31125.

Diff Detail

Event Timeline

foad created this revision.Jan 23 2023, 7:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 7:01 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
foad requested review of this revision.Jan 23 2023, 7:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 7:01 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B209368: Diff 491359.Jan 23 2023, 8:26 AM
beanz accepted this revision.Jan 23 2023, 1:32 PM

LGTM.

This revision is now accepted and ready to land.Jan 23 2023, 1:32 PM
This revision was landed with ongoing or failed builds.Jan 24 2023, 12:27 AM
Closed by commit rGcdb226433f1b: [cmake] Remove AddLLVMDefinitions (authored by foad). · Explain Why
This revision was automatically updated to reflect the committed changes.
foad added a commit: rGcdb226433f1b: [cmake] Remove AddLLVMDefinitions.

Revision Contents

PathSize
llvm/
cmake/
modules/

Diff 491631

llvm/cmake/modules/AddLLVMDefinitions.cmake

  • This file was deleted.
# There is no clear way of keeping track of compiler command-line
# options chosen via `add_definitions', so we need our own method for
# using it on tools/llvm-config/CMakeLists.txt.
# Beware that there is no implementation of remove_llvm_definitions.
macro(add_llvm_definitions)
# We don't want no semicolons on LLVM_DEFINITIONS:
foreach(arg ${ARGN})
if(DEFINED LLVM_DEFINITIONS)
set(LLVM_DEFINITIONS "${LLVM_DEFINITIONS} ${arg}")
else()
set(LLVM_DEFINITIONS ${arg})
endif()
endforeach(arg)
add_definitions( ${ARGN} )
endmacro(add_llvm_definitions)