This is an archive of the discontinued LLVM Phabricator instance.

LLVMProcessSources.cmake: Improve PARTIAL_SOURCES_INTENDED.
ClosedPublic

Authored by chapuni on Jan 20 2023, 2:36 PM.

Details

Summary

The last non-partial-specified target can collect and check source files.

Case A:

llvm_add_library(foo PARTIAL_SOURCES_INTENDED ...)
llvm_add_library(bar PARTIAL_SOURCES_INTENDED ...)
llvm_add_library(baz ...)

baz checks source files in foo, bar, and baz.

Case B:

llvm_add_library(hoge PARTIAL_SOURCES_INTENDED ...)
llvm_add_library(fuga PARTIAL_SOURCES_INTENDED ...)
llvm_add_library(piyo PARTIAL_SOURCES_INTENDED ...)
llvm_check_source_file_list() # Explicitly checks sources in hoge, fuga, and piyo.

LLVMFuzzerCLI: [CMake] Prune the last PARTIAL_SOURCES_INTENDED to cover all sources.

Diff Detail

Event Timeline

chapuni created this revision.Jan 20 2023, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 2:36 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
chapuni requested review of this revision.Jan 20 2023, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 2:36 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2023, 3:13 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

I have committed this since I thought this is a trivial change with one user.