When working out whether we can see a compressible jump-table pattern during ConstantIslands, we were stopping when we saw a debug instruction. Instead it's better to keep iterating backwards to the first real instruction.
Details
Details
Diff Detail
Diff Detail
Unit Tests
Unit Tests
Event Timeline
llvm/lib/Target/ARM/ARMConstantIslandPass.cpp | ||
---|---|---|
2290–2292 | I believe you should be able to use skipDebugInstructionsBackward to achieve this more concisely. |
Comment Actions
Oh, thanks. I thought I'd seen something like that but only turned up the IR-level ones in my search. Switched. Also sanitized some of the strings in the test.
Comment Actions
LGTM from a debug-info perspective; I know next to nothing about ARM though so can't venture an opinion there. A smaller test would be appreciated if that's possible.
(NB: with no reviewers this will be getting little visibility, this showed up for me as I filter for debug-info stuff).
Comment Actions
Thanks, resynthesized a test from a much smaller, single, switch and committed as dc700f1e4daf.
I believe you should be able to use skipDebugInstructionsBackward to achieve this more concisely.