This is an archive of the discontinued LLVM Phabricator instance.

[llvm][NFC] Apply performance-noexcept-move-constructor to llvm core
Needs ReviewPublic

Authored by Skylion007 on Jan 16 2023, 11:01 AM.

Details

Summary

Applies performance-noexcept-move-constructor to llvm core. One would think that this check does not matter since we do not allow exceptions due to the LLVM styleguide. However, STL containers (including std::variant and std::optional) do check the noexcept tag to see if it's safe to move. Therefore, we should make all these classes as safe to move so these STL containers can be as efficient as possible.

Diff Detail

Event Timeline

Skylion007 created this revision.Jan 16 2023, 11:01 AM
Skylion007 requested review of this revision.Jan 16 2023, 11:01 AM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript

Made sure headers updated too. Skip support and ADT files for now.

Fixed forward declare bug

Fix forward declare typo

Fix forward declare typo

Fix another forward declare

Make jitlink cpp match

Fixup one another cpp error

revert changes to JITLink